Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0 stable] Update eden to the latest version 0.9.11 #4260

Open
wants to merge 1 commit into
base: 11.0-stable
Choose a base branch
from

Conversation

milan-zededa
Copy link
Contributor

Try the latest eden version in the 11.0-stable branch. Currently, most of the test suites are failing on that branch and are therefore pretty much useless.

Signed-off-by: Milan Lenco [email protected]
(cherry picked from commit b283541)

Try the latest eden version in the 11.0-stable branch.
Currently, most of the test suites are failing on that branch and are
therefore pretty much useless.

Signed-off-by: Milan Lenco <[email protected]>
(cherry picked from commit b283541)
@milan-zededa milan-zededa changed the title Update eden to the latest version 0.9.11 [11.0 stable] Update eden to the latest version 0.9.11 Sep 16, 2024
@OhmSpectator
Copy link
Member

Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test it

@milan-zededa
Copy link
Contributor Author

We will have to come back to this tomorrow since we have reached dockerhub pull limits.

@OhmSpectator
Copy link
Member

time: 2024-09-16T23:46:19.880587284Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530378  nanos:500862442}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:46:33.894198307Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530393  nanos:158952572}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:46:58.913477789Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530418  nanos:404939510}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:47:28.938442754Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530447  nanos:957586000}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:47:53.957006423Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530473  nanos:454141348}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:48:20.975479467Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530500  nanos:39960119}  severity:SEVERITY_ERRO

@milan-zededa
Copy link
Contributor Author

time: 2024-09-16T23:46:19.880587284Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530378  nanos:500862442}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:46:33.894198307Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530393  nanos:158952572}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:46:58.913477789Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530418  nanos:404939510}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:47:28.938442754Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530447  nanos:957586000}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:47:53.957006423Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530473  nanos:454141348}  severity:SEVERITY_ERROR]
time: 2024-09-16T23:48:20.975479467Z out: 	appName eclient state changed to INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable \"#cloud-config\" not defined properly\nKey value pair should be delimited by \"=\""  timestamp:{seconds:1726530500  nanos:39960119}  severity:SEVERITY_ERRO

This is failing because eden is testing feature that was developed after 11.0
We will probably have to create a separate branch for eden to test EVE 11.0.x

@OhmSpectator
Copy link
Member


This is failing because eden is testing feature that was developed after 11.0
We will probably have to create a separate branch for eden to test EVE 11.0.x

Looks complicated =(

But, in general, it would be nice to understand how we deal with Eden from the maintainability perspective. Do we duplicate the LTS branches logic there as well? How do we backport? I think using the same approach as the main EVE repo would make sense...

@uncleDecart
Copy link
Contributor

Because of backward incompatibility we maintained stable branches on eden , as you can see in change you're switching from 0.9.3-stable to 0.9.11, 0.9.3-stable is a branch in eden, where you can cherry-pick changes of eden tests, so that they can reflex backport fixes without creating the problem. Ideally, we need to keep a table somewhere (question is where) where we map EVE version to Eden, so far what I've been doing is specifying EVE version in each Eden release, in release notes. You can see those here

I'd suggest we create either md file called MAINTAINING.md or a GitHub wiki page describing this process :) and mention them in PR template and/or issue template

@OhmSpectator hope that answers your question :)

@milan-zededa
Copy link
Contributor Author

Because of backward incompatibility we maintained stable branches on eden , as you can see in change you're switching from 0.9.3-stable to 0.9.11, 0.9.3-stable is a branch in eden, where you can cherry-pick changes of eden tests, so that they can reflex backport fixes without creating the problem. Ideally, we need to keep a table somewhere (question is where) where we map EVE version to Eden, so far what I've been doing is specifying EVE version in each Eden release, in release notes. You can see those here

I'd suggest we create either md file called MAINTAINING.md or a GitHub wiki page describing this process :) and mention them in PR template and/or issue template

@OhmSpectator hope that answers your question :)

The problem is that 0.9.3-stable is not stable at all. Tests are failing miserably. The set of commits we would need to backport to make that version useful is pretty long. At the same time, the test that Paul added for writing files to containers from cloud-init config (which 11.0 does not yet support) is already in eden 0.9.5, before the commits stabilizing eden tests came in. So I do not really know how to deal with this situation.

@uncleDecart
Copy link
Contributor

The problem is that 0.9.3-stable is not stable at all. Tests are failing miserably. The set of commits we would need to backport to make that version useful is pretty long. At the same time, the test that Paul added for writing files to containers from cloud-init config (which 11.0 does not yet support) is already in eden 0.9.5, before the commits stabilizing eden tests came in. So I do not really know how to deal with this situation.

Well, we can put proper process in place moving forward. But can we use 0.9.4, or stabilizing came in 0.9.5 ? And how hard would be cherry-picking stabilizing commits to 0.9.3-stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants