Bump openssl from 0.10.54 to 0.10.55 (#42) #70
mantonoAnnotations
8 warnings
|
redundant clone:
src/ui.rs#L73
warning: redundant clone
--> src/ui.rs:73:41
|
73 | issue.repository.name_with_owner.clone()
| ^^^^^^^^ help: remove this
|
note: cloned value is neither consumed nor mutated
--> src/ui.rs:73:9
|
73 | issue.repository.name_with_owner.clone()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: `#[warn(clippy::redundant_clone)]` on by default
|
|
useless conversion to the same type: `regex::Matches<'_, '_>`:
src/target.rs#L19
warning: useless conversion to the same type: `regex::Matches<'_, '_>`
--> src/target.rs:19:34
|
19 | let parts: Vec<String> = TARGET
| __________________________________^
20 | | .find_iter(s)
21 | | .into_iter()
| |________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
|
19 ~ let parts: Vec<String> = TARGET
20 + .find_iter(s)
|
|
|
this `impl` can be derived:
src/sort.rs#L89
warning: this `impl` can be derived
--> src/sort.rs:89:1
|
89 | / impl Default for Order {
90 | | fn default() -> Self {
91 | | Order::Descending
92 | | }
93 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
84 + #[derive(Default)]
85 | pub enum Order {
|
help: ...and mark the default variant
|
85 ~ #[default]
86 ~ Descending,
|
|
|
this `impl` can be derived:
src/sort.rs#L51
warning: this `impl` can be derived
--> src/sort.rs:51:1
|
51 | / impl Default for Property {
52 | | fn default() -> Self {
53 | | Property::Updated
54 | | }
55 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
24 + #[derive(Default)]
25 | pub enum Property {
|
help: ...and mark the default variant
|
26 ~ #[default]
27 ~ Updated,
|
|
|
manual implementation of `Option::map`:
src/search.rs#L107
warning: manual implementation of `Option::map`
--> src/search.rs:107:9
|
107 | / match &self.assignee {
108 | | Some(name) => Some(format!("assignee:{}", name)),
109 | | None => None,
110 | | }
| |_________^ help: try this: `self.assignee.as_ref().map(|name| format!("assignee:{}", name))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/list.rs#L132
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/list.rs:132:50
|
132 | let query: SearchIssues = create_query(kind, &user, targets, config);
| ^^^^^ help: change this to: `user`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
src/args.rs#L6
warning: the borrowed expression implements the required traits
--> src/args.rs:6:51
|
6 | let repo_root: PathBuf = match giro::git_root(¤t_path).unwrap() {
| ^^^^^^^^^^^^^ help: change this to: `current_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
method `types` is never used:
src/list.rs#L32
warning: method `types` is never used
--> src/list.rs:32:12
|
31 | impl FilterConfig {
| ----------------- method in this implementation
32 | pub fn types(&self) -> Vec<Type> {
| ^^^^^
|
= note: `#[warn(dead_code)]` on by default
|