Skip to content

Bump openssl from 0.10.54 to 0.10.55 (#42) #70

Bump openssl from 0.10.54 to 0.10.55 (#42)

Bump openssl from 0.10.54 to 0.10.55 (#42) #70

GitHub Actions / clippy succeeded Jun 22, 2023 in 0s

clippy

8 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 8
Note 0
Help 0

Versions

  • rustc 1.70.0 (90c541806 2023-05-31)
  • cargo 1.70.0 (ec8a8a0ca 2023-04-25)
  • clippy 0.1.70 (90c5418 2023-05-31)

Annotations

Check warning on line 73 in src/ui.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant clone

warning: redundant clone
  --> src/ui.rs:73:41
   |
73 |         issue.repository.name_with_owner.clone()
   |                                         ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> src/ui.rs:73:9
   |
73 |         issue.repository.name_with_owner.clone()
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
   = note: `#[warn(clippy::redundant_clone)]` on by default

Check warning on line 21 in src/target.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `regex::Matches<'_, '_>`

warning: useless conversion to the same type: `regex::Matches<'_, '_>`
  --> src/target.rs:19:34
   |
19 |           let parts: Vec<String> = TARGET
   |  __________________________________^
20 | |             .find_iter(s)
21 | |             .into_iter()
   | |________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
   |
19 ~         let parts: Vec<String> = TARGET
20 +             .find_iter(s)
   |

Check warning on line 93 in src/sort.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived

warning: this `impl` can be derived
  --> src/sort.rs:89:1
   |
89 | / impl Default for Order {
90 | |     fn default() -> Self {
91 | |         Order::Descending
92 | |     }
93 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = help: remove the manual implementation...
help: ...and instead derive it...
   |
84 + #[derive(Default)]
85 | pub enum Order {
   |
help: ...and mark the default variant
   |
85 ~     #[default]
86 ~     Descending,
   |

Check warning on line 55 in src/sort.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived

warning: this `impl` can be derived
  --> src/sort.rs:51:1
   |
51 | / impl Default for Property {
52 | |     fn default() -> Self {
53 | |         Property::Updated
54 | |     }
55 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it...
   |
24 + #[derive(Default)]
25 | pub enum Property {
   |
help: ...and mark the default variant
   |
26 ~     #[default]
27 ~     Updated,
   |

Check warning on line 110 in src/search.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of `Option::map`

warning: manual implementation of `Option::map`
   --> src/search.rs:107:9
    |
107 | /         match &self.assignee {
108 | |             Some(name) => Some(format!("assignee:{}", name)),
109 | |             None => None,
110 | |         }
    | |_________^ help: try this: `self.assignee.as_ref().map(|name| format!("assignee:{}", name))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
    = note: `#[warn(clippy::manual_map)]` on by default

Check warning on line 132 in src/list.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/list.rs:132:50
    |
132 |     let query: SearchIssues = create_query(kind, &user, targets, config);
    |                                                  ^^^^^ help: change this to: `user`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 6 in src/args.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
 --> src/args.rs:6:51
  |
6 |     let repo_root: PathBuf = match giro::git_root(&current_path).unwrap() {
  |                                                   ^^^^^^^^^^^^^ help: change this to: `current_path`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
  = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 32 in src/list.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `types` is never used

warning: method `types` is never used
  --> src/list.rs:32:12
   |
31 | impl FilterConfig {
   | ----------------- method in this implementation
32 |     pub fn types(&self) -> Vec<Type> {
   |            ^^^^^
   |
   = note: `#[warn(dead_code)]` on by default