Add speed limit data returned by MapboxDirections.swift to the RouteProgress object #2114
Conversation
There was a problem hiding this comment.
Thanks, I think this PR is all set as far as the current API is concerned. Some upcoming changes to the API will require minimal additional work here (to determine the currently relevant sign style and unit), and we’ll have to revive the UI in #1242 before we can consider the feature complete, but this is a good foundation for a non-production application to prototype a UI.
All the builds are failing on CI, likely because Cartfile.resolved hasn’t been updated to reflect the changes in Cartfile.
| @@ -25,7 +25,11 @@ open class NavigationRouteOptions: RouteOptions { | |||
| shapeFormat = .polyline6 | |||
| includesSteps = true | |||
| routeShapeResolution = .full | |||
| attributeOptions = [.congestionLevel, .expectedTravelTime, .maximumSpeedLimit] | |||
| if profileIdentifier == .walking { | |||
There was a problem hiding this comment.
profileIdentifier is mutable, so technically it’s possible for the developer to change the profile identifier to walking after initializing the object. We could address that case by conditionally adding maximumSpeedLimit in an override of the URLQueryItems property instead of this initializer. But maybe it isn’t a big deal.
1ec5
force-pushed
the
maxspeedAnnotations
branch
from
4b35798 to
3012c53
Compare
1ec5
added
feature
|
Once mapbox/mapbox-directions-swift#379 lands, this PR will be blocked by #2206. |
|
This PR is no longer blocked by either mapbox/mapbox-directions-swift#379 or #2206. However, mapbox/mapbox-directions-swift#250 does need to land first. |
|
This PR needs to be rebased to resolve conflicts, but mapbox/mapbox-directions-swift#250 depends on mapbox/mapbox-directions-swift#382, which master is incompatible with. #2275 fixes some of the compatibility issues but isn’t ready yet, and it depends on mapbox/mapbox-directions-swift#393, which isn’t ready either. 🤕 |
1ec5
force-pushed
the
maxspeedAnnotations
branch
from
589e1dc to
7bbdb60
Compare
1ec5
removed
the
UI
…imit for the route progress.
… a segment and not be considered evenly distributed along the segment coordinates.
…edLimit per route segment array in favor of positioned SpeedLimit tuples.
…ofile request since they are invalid for that profile. Rework the logic for including maximumSpeedLimits annotations to restrict them to auto driving profiles.
…en the current speed limit is queried for.
Get just the current segment’s speed limit instead of bucketing the speed limits upfront.
1ec5
force-pushed
the
maxspeedAnnotations
branch
from
8631b54 to
3339380
Compare
Shifting from PR #2112
Incorporate the new maxspeed annotations on the RouteLeg object from MapboxDirections.swift. Provide this data to Navigation SDK clients via the
maximumSpeedLimitsByLeg array on the RouteProgress objectRouteLegProgress.currentSpeedLimitproperty.