Upgrade to post-Objective-C MapboxDirections.swift #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JThramer
added
op-ex
1ec5
reviewed
Nov 26, 2019
There was a problem hiding this comment.
In addition to the feedback below, please audit all other usage of the Polyline() initializer. There are plenty of opportunities to eliminate excessive copying of coordinate arrays, for example here where routeLine comes from a step’s shape property, which is already a Polyline:
1ec5
reviewed
Dec 17, 2019
|
|
||
| extension Route { | ||
|
|
||
| var json: String? { |
There was a problem hiding this comment.
Encoding as JSON is expensive enough that we probably shouldn’t hand-wave away the fact that this computed variable creates a new structure every time it is accessed. Instead, make it a method.
Once we implement mapbox/mapbox-directions-swift#391, the original JSON data can live alongside the decoded Route in a Response object.
1ec5
reviewed
Dec 19, 2019
1ec5
reviewed
Dec 20, 2019
|
This PR blocks #2114: #2114 (comment). |
This comment has been minimized.
This comment has been minimized.
1ec5
changed the title
1ec5
force-pushed
the
jerrad/delenda-duet
branch
from
acfb7d7 to
4bffafd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1ec5
reviewed
Dec 24, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Rely on encoding and decoding to copy the object instead of manually copying each individual property, which is error-prone (and incomplete).
route-doubling-back.json was apparently generated with 5 digits of precision.
Coordinates are now round-tripped through Polyline encoding, so they get rounded to 5 or 6 places. What matters is that they’re still really close to the mark in terms of physical distances.
Build up a single attributed string as a container, embedding abbreviations in attributes.
1ec5
force-pushed
the
jerrad/delenda-duet
branch
from
8d12f8c to
a5942cb
Compare
1ec5
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to track integration between #2230 (now merged) and mapbox/mapbox-directions-swift#382.
Burn-down list:
NSCoder->CodablerefactoringsRouteOptionsDepends on mapbox/mapbox-directions-swift#393.
/cc @mapbox/navigation-ios