fix: validating prometheus target #1077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almostinf
reviewed
Aug 30, 2024
almostinf
reviewed
Aug 30, 2024
almostinf
reviewed
Aug 30, 2024
almostinf
previously approved these changes
Sep 3, 2024
almostinf
reviewed
Sep 3, 2024
…metheus errors (except bad data error type)
almostinf
previously approved these changes
Sep 10, 2024
Tetrergeru
reviewed
Sep 13, 2024
| @@ -9,6 +9,8 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| prometheus "github.com/prometheus/client_golang/api/prometheus/v1" | |||
There was a problem hiding this comment.
А проверял как-то, что на выражениях, специфичных для виктории, ничего не поедет?
|
/build |
|
/build |
|
/build |
|
Build and push Docker images with tag: fix-validating-prometheus-target.2024-09-20.edfaa20 |
2 similar comments
|
Build and push Docker images with tag: fix-validating-prometheus-target.2024-09-20.edfaa20 |
|
Build and push Docker images with tag: fix-validating-prometheus-target.2024-09-20.edfaa20 |
almostinf
reviewed
Sep 20, 2024
| http.StatusForbidden: {}, | ||
| } | ||
|
|
||
| if _, leadTo500 := codes4xxLeadTo500[statusCode]; statusCode/100 == 4 && !leadTo500 { |
There was a problem hiding this comment.
statusCode/100 == 4 давай вынесем в функцию определяющую 400ый код + я бы все же переписал на statusCode >= 400 && statusCode < 500 просто из-за читаемости
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the status code and returned description
Before this PR on any error from prometheus the response with status code 500 was returned.
Now if the error is caused by bad target the response with status code 400 is returned.