-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validating prometheus target #1077
Open
AleksandrMatsko
wants to merge
12
commits into
master
Choose a base branch
from
fix/validating-prometheus-target
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
797daa1
feat: prometheus error handling in getTriggerFromRequest and in trigg…
AleksandrMatsko f02ae6c
refactor: error message
AleksandrMatsko 80eb5fd
test: for handling errors returned from prometheus
AleksandrMatsko cec15c1
test: for graphite remote
AleksandrMatsko 389994d
style: use linter
AleksandrMatsko 681a1eb
merge origin/master into fix/validating-prometheus-target
AleksandrMatsko e5a223c
refactor: change status code returned by `/api/trigger/check` for pro…
AleksandrMatsko dfba55e
merge master into fix/validating-prometheus-target
AleksandrMatsko d6cd538
refactor: add debug prints for error handling
AleksandrMatsko 339fd16
refactor: remove debug prints
AleksandrMatsko f219c88
fix: handling error type of prometheus errors
AleksandrMatsko edfaa20
fix: add return statement, use linter
AleksandrMatsko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А проверял как-то, что на выражениях, специфичных для виктории, ничего не поедет?