This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
[release-8.3] Fix 988924: Some commands (save, undo) do not work if editor is detat… #9220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandyarmstrong
added
Area: VS Text Editor
sandyarmstrong
force-pushed
the
backport-pr-9218-to-release-8.3
branch
from
f744aee
to
0c62a9a
Compare
|
@monojenkins rebase |
…ched from IDE into its own window Problem is that when command comes in, it first goes to CocoaTextViewControl and then up NSView treeview, problem starts when migrating to GTK treeview because GtkNSViewHost is not set as it should be, after debugging why this happens it appears that `GetFocusedChild` method wasn't returning `GtkNSViewHost` as expected, upon further debugging it turns out thats because logic of drilling down GTK treeview doesn't work because `GetFocusedChild` parameter is `NSWindow` instead of `GtkWindow`. So fix is to convert `NSWindow` to `GtkWindow` and now everything works as expected. Reason we are getting `NSWindow` instead of `GtkWindow` is somewhere in `GetActiveWindow` method, but I'm not sure if its bug or not....
monojenkins
force-pushed
the
backport-pr-9218-to-release-8.3
branch
from
0c62a9a
to
a83369a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ched from IDE into its own window
Problem is that when command comes in, it first goes to CocoaTextViewControl and then up NSView treeview, problem starts when migrating to GTK treeview because GtkNSViewHost is not set as it should be, after debugging why this happens it appears that
GetFocusedChildmethod wasn't returningGtkNSViewHostas expected, upon further debugging it turns out thats because logic of drilling down GTK treeview doesn't work becauseGetFocusedChildparameter isNSWindowinstead ofGtkWindow. So fix is to convertNSWindowtoGtkWindowand now everything works as expected. Reason we are gettingNSWindowinstead ofGtkWindowis somewhere inGetActiveWindowmethod, but I'm not sure if its bug or not....Backport of #9218.
/cc @sandyarmstrong @DavidKarlas