Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

[release-8.3] Fix 988924: Some commands (save, undo) do not work if editor is detat… #9220

Open
wants to merge 1 commit into
base: release-8.3
Choose a base branch
from

Commits on Nov 8, 2019

  1. Fix 988924: Some commands (save, undo) do not work if editor is detat…

    …ched from IDE into its own window
    
    Problem is that when command comes in, it first goes to CocoaTextViewControl and then up NSView treeview, problem starts when migrating to GTK treeview because GtkNSViewHost is not set as it should be, after debugging why this happens it appears that `GetFocusedChild` method wasn't returning `GtkNSViewHost` as expected, upon further debugging it turns out thats because logic of drilling down GTK treeview doesn't work because `GetFocusedChild` parameter is `NSWindow` instead of `GtkWindow`. So fix is to convert `NSWindow` to `GtkWindow` and now everything works as expected. Reason we are getting `NSWindow` instead of `GtkWindow` is somewhere in `GetActiveWindow` method, but I'm not sure if its bug or not....
    DavidKarlas authored and monojenkins committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    a83369a View commit details
    Browse the repository at this point in the history