WIP: Isolate Drawer menu from the rest of the UI #3773
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
grebaldi
force-pushed
the
feature/multi-app/02-loosen-the-menu
branch
2 times, most recently
from
5666f1d
to
acbdd0a
Compare
…ui-error package
This introduces a very basic implementation of the observable pattern for the Neos UI. This will allow us to replace redux opportunistically in various places.
This new package contains react bindings for the other recently introduced package `@neos-project/framework-observable`.
...by using the newly introduced observable primitives. The neos-ui-error package now exposes a method to show flash messages. A saga has been created to redirect redux actions (that may still be used in plugins) to that method.
…owFlashMessage` API
…' into temp/3972-3804
Until now, dropdown contents were `null`ed when the dropdown is closed. This leads to unneccessary re-renders every time the dropdown visibility is toggled. This commit changes this logic. Dropdown contents are now always rendered, but hidden when the dropdown is closed.
grebaldi
force-pushed
the
feature/multi-app/02-loosen-the-menu
branch
from
4c78c28
to
ebaf71e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #3119
previous: #3682
depends on: #3792, #3804
WIP.