Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Isolate Drawer menu from the rest of the UI #3773

Draft
wants to merge 71 commits into
base: 9.0
Choose a base branch
from
Draft

WIP: Isolate Drawer menu from the rest of the UI #3773

wants to merge 71 commits into from

Commits on Jun 11, 2024

  1. TASK: Convert FlashMessage component to typescript

    @grebaldi
    grebaldi committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a9b33d1 View commit details
    Browse the repository at this point in the history

  2. TASK: Convert FlashMessages component to typescript

    @grebaldi
    grebaldi committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    10068f1 View commit details
    Browse the repository at this point in the history

  3. TASK: Move ErrorView component into ./container/ directory

    @grebaldi
    grebaldi committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    28f91a3 View commit details
    Browse the repository at this point in the history

  4. TASK: Move ErrorBoundary component to neos-ui-error package

    @grebaldi
    grebaldi committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    57af79b View commit details
    Browse the repository at this point in the history

  5. TASK: Move function terminateDueToFatalInitializationError to neos-… 

    …ui-error package
    @grebaldi
    grebaldi committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    492f0cd View commit details
    Browse the repository at this point in the history

  6. TASK: Move component FlashMessages to neos-ui-error package

    @grebaldi
    grebaldi committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7cd6b2d View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. TASK: Add package @neos-project/framework-observable 

    This introduces a very basic implementation of the observable pattern
for the Neos UI.

This will allow us to replace redux opportunistically in various places.
    @grebaldi
    grebaldi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2538b85 View commit details
    Browse the repository at this point in the history

  2. TASK: Add package @neos-project/framework-observable-react 

    This new package contains react bindings for the other recently
introduced package `@neos-project/framework-observable`.
    @grebaldi
    grebaldi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3a9090e View commit details
    Browse the repository at this point in the history

  3. TASK: Decouple FlashMessage from redux store 

    ...by using the newly introduced observable primitives. The
neos-ui-error package now exposes a method to show flash messages.

A saga has been created to redirect redux actions (that may still be
used in plugins) to that method.
    @grebaldi
    grebaldi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ff458b6 View commit details
    Browse the repository at this point in the history

  4. !!!TASK: Delete obsolete redux-store elements for flash messages

    @grebaldi
    grebaldi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2258a0b View commit details
    Browse the repository at this point in the history

  5. TASK: Replace all calls to action.UI.FlashMessages.add with new `sh… 

    …owFlashMessage` API
    @grebaldi
    grebaldi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2caf38a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. TASK: Implement TranslationAddress value object

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8823c4f View commit details
    Browse the repository at this point in the history

  2. TASK: Extract function getTranslationAddress

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    1c714e9 View commit details
    Browse the repository at this point in the history

  3. TASK: Extract function substitutePlaceholders

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9cf40bd View commit details
    Browse the repository at this point in the history

  4. TASK: Extract function getPluralForm

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    76614b5 View commit details
    Browse the repository at this point in the history

  5. TASK: Convert I18nRegistry to typescript

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c5f98b4 View commit details
    Browse the repository at this point in the history

  6. TASK: Return actual TranslationAddress from getTranslationAddress

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c3d5300 View commit details
    Browse the repository at this point in the history

  7. TASK: Introduce TranslationUnitRepository

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    fa66f2a View commit details
    Browse the repository at this point in the history

  8. TASK: Preserve fully qualified translation address

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d35af00 View commit details
    Browse the repository at this point in the history

  9. TASK: Fix misnomer f.q. trans-unit id -> f.q. translation address

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f579a54 View commit details
    Browse the repository at this point in the history

  10. TASK: Use TranslationUnitRepository for translation lookup in I18nReg… 

    …istry
    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    99179ad View commit details
    Browse the repository at this point in the history

  11. TASK: Rename TranslationUnit -> TranslationUnitDTO

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0f6fde3 View commit details
    Browse the repository at this point in the history

  12. TASK: Introduce TranslationUnit value object

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6b839e0 View commit details
    Browse the repository at this point in the history

  13. TASK: Integrate TranslationUnit with I18nRegistry

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    eac4a03 View commit details
    Browse the repository at this point in the history

  14. TASK: Remove obsolete function getPluralForm

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    fc046ea View commit details
    Browse the repository at this point in the history

  15. TASK: Convert neos-ui-i18n/src/registry/I18nRegistry.spec.js to TypeS… 

    …cript
    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ed34e6a View commit details
    Browse the repository at this point in the history

  16. TASK: Turn I18nRegistry into a singleton

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    339684d View commit details
    Browse the repository at this point in the history

  17. TASK: Make <I18n> component independent from global registry

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3c94d1e View commit details
    Browse the repository at this point in the history

  18. TASK: Expose I18nRegistry through i18n package rather than neos-ts-in… 

    …terfaces
    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b60daf3 View commit details
    Browse the repository at this point in the history

  19. TASK: Convert neos-ui-i18n/index.spec.js to TypeScript

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2d6e743 View commit details
    Browse the repository at this point in the history

  20. TASK: Rename TranslationUnit -> Translation

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7a06dea View commit details
    Browse the repository at this point in the history

  21. TASK: Expose function registerTranslations from @neos-project/neos-… 

    …ui-i18n
    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5ecfb4f View commit details
    Browse the repository at this point in the history

  22. TASK: Discover translations endpoint via <link>-tag

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6da83b4 View commit details
    Browse the repository at this point in the history

  23. TASK: Introduce Locale & PluralRule models

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9375354 View commit details
    Browse the repository at this point in the history

  24. TASK: Expose registerLocale and use it in bootstrap process

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e6716fb View commit details
    Browse the repository at this point in the history

  25. !!!BUGFIX: Use Intl plurals for proper plural form determination

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    61168df View commit details
    Browse the repository at this point in the history

  26. FEATURE: Implement and expose API translate function

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    497a345 View commit details
    Browse the repository at this point in the history

  27. TASK: Centralize setup of globals for @neos-project/neos-ui-i18n

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    77dfdda View commit details
    Browse the repository at this point in the history

  28. TASK: Implement, expose and use initializeI18n

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f5eb665 View commit details
    Browse the repository at this point in the history

  29. TASK: Move Translation into model module

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5278b3e View commit details
    Browse the repository at this point in the history

  30. TASK: Move TranslationAddress into model module

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    047a39f View commit details
    Browse the repository at this point in the history

  31. TASK: Move TranslationRepository into model module

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    16f3efb View commit details
    Browse the repository at this point in the history

  32. TASK: Rename Parameters -> LegacyParameters

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0431bdf View commit details
    Browse the repository at this point in the history

  33. TASK: Introduce proper Parameters type

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    1ac7864 View commit details
    Browse the repository at this point in the history

  34. TASK: Move <I18n/>-component into separate module

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c567182 View commit details
    Browse the repository at this point in the history

  35. TASK: Deprecate I18nRegistry.translate

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a875f9a View commit details
    Browse the repository at this point in the history

  36. TASK: Deprecate I18nRegistry

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6c2fd85 View commit details
    Browse the repository at this point in the history

  37. TASK: Deprecate <I18n/>-component

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9f46e0a View commit details
    Browse the repository at this point in the history

  38. TASK: Add documentation for @neos-project/neos-ui-i18n package

    @grebaldi
    grebaldi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    232e6a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Merge remote-tracking branch 'upstream/task/centralize-error-handling… 

    …' into temp/3972-3804
    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    4131c8a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/task/centralize-i18n' into tem… 

    …p/3972-3804
    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    15c94f3 View commit details
    Browse the repository at this point in the history

  3. !!!TASK: Split user key from initialData via separate UserProvider

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    26cebfe View commit details
    Browse the repository at this point in the history

  4. TASK: Convert <UserImage/> container to typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1d5f669 View commit details
    Browse the repository at this point in the history

  5. TASK: Convert <RestoreButtonItem/> container to typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    916059f View commit details
    Browse the repository at this point in the history

  6. TASK: Convert <UserDropDown/> container to typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    437fa07 View commit details
    Browse the repository at this point in the history

  7. PATCH: Fix typing in UserProviderInterface

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0d83a02 View commit details
    Browse the repository at this point in the history

  8. TASK: Convert parsing of initial data to Typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    91a8f8b View commit details
    Browse the repository at this point in the history

  9. TASK: Make aliasoptional in initializeJsAPI

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    23511f4 View commit details
    Browse the repository at this point in the history

  10. TASK: Detach user menu from redux store

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5691af5 View commit details
    Browse the repository at this point in the history

  11. BUGFIX: Render dropdown contents even when dropdown is closed 

    Until now, dropdown contents were `null`ed when the dropdown is closed.
This leads to unneccessary re-renders every time the dropdown visibility
is toggled.

This commit changes this logic. Dropdown contents are now always
rendered, but hidden when the dropdown is closed.
    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f440199 View commit details
    Browse the repository at this point in the history

  12. TASK: Convert VersionPanel component to typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7393f33 View commit details
    Browse the repository at this point in the history

  13. TASK: Convert Drawer/constants to typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0da253e View commit details
    Browse the repository at this point in the history

  14. TASK: Convert Drawer/MenuItem component to typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    393902b View commit details
    Browse the repository at this point in the history

  15. TASK: Convert Drawer/MenuItemGroup to typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    46e8ba0 View commit details
    Browse the repository at this point in the history

  16. TASK: Convert Drawer component to typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    22dcadf View commit details
    Browse the repository at this point in the history

  17. PATCH: Don't pass user down to Drawer & UserDropDown

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1ef89fd View commit details
    Browse the repository at this point in the history

  18. PATCH: Move impersonateRestore out of the redux store

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    87300fa View commit details
    Browse the repository at this point in the history

  19. PATCH: Move impersonateRestore out of the redux store part II

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c4a3d71 View commit details
    Browse the repository at this point in the history

  20. TASK: Remove unused target property from drawer menu items

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c6b1383 View commit details
    Browse the repository at this point in the history

  21. TASK: Convert MenuToggler to typescript

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    40b2697 View commit details
    Browse the repository at this point in the history

  22. TASK: Decouple Drawer from redux store

    @grebaldi
    grebaldi committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ebaf71e View commit details
    Browse the repository at this point in the history