Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for php 8.4 #3038

Merged
merged 4 commits into from
Feb 16, 2025
Merged

Updates for php 8.4 #3038

merged 4 commits into from
Feb 16, 2025

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Jan 9, 2025

  • Resolves: #

Summary

This PR will focus on enabling news to run on php 8.4

Checklist

@Grotax Grotax changed the title wip Updates for php 8.4 Jan 9, 2025
@Grotax
Copy link
Member Author

Grotax commented Jan 9, 2025

I think feed-io would still require some love, it already now throws deprecation warnings under php 8.3 (reported by users)

I checked the official docker image we use in /docker runs on php 8.2 and there are no other versions

The dev image we use for the devcontainer only goes up to php 8.3 at this moment https://juliusknorr.github.io/nextcloud-docker-dev/customizing/config/#php-version

@blizzz
Copy link
Member

blizzz commented Jan 14, 2025

maybe i am mistaken something, but nextcloud-docker-dev does seem to have a PHP 8.4 containers since juliusknorr/nextcloud-docker-dev#359

@Grotax
Copy link
Member Author

Grotax commented Jan 30, 2025

The config was added but docs not updated and the image build also failed looks like some extensions might be missing.

https://github.com/juliusknorr/nextcloud-docker-dev/actions/runs/12005496728/job/33462208649

Also update other packages

Signed-off-by: Benjamin Brahmer <[email protected]>
Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax marked this pull request as ready for review February 16, 2025 10:40
@Grotax Grotax merged commit 7b3e0b6 into master Feb 16, 2025
26 checks passed
@Grotax Grotax deleted the actions/update branch February 16, 2025 10:41
Grotax added a commit that referenced this pull request Feb 16, 2025
Changed
- Enable support for php 8.4 (#3038)
- Enable support for Nextcloud 31 (#3089)

Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax mentioned this pull request Feb 16, 2025
Grotax added a commit that referenced this pull request Feb 16, 2025
Changed
- Enable support for php 8.4 (#3038)
- Enable support for Nextcloud 31 (#3089)

Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants