Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mirtop version #6663

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Update mirtop version #6663

merged 5 commits into from
Sep 20, 2024

Conversation

atrigila
Copy link
Contributor

@atrigila atrigila commented Sep 18, 2024 •
edited
Loading

Update mirtop to latest version and add checks for stable md5sum

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@atrigila atrigila requested a review from a team as a code owner September 18, 2024 16:25
@atrigila atrigila requested review from kpadm and removed request for a team September 18, 2024 16:25
@atrigila atrigila added the WIP Work in progress label Sep 19, 2024
@atrigila atrigila added Ready for Review and removed WIP Work in progress labels Sep 19, 2024
apeltzer
apeltzer approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@apeltzer apeltzer added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@apeltzer apeltzer added this pull request to the merge queue Sep 20, 2024
Merged via the queue into nf-core:master with commit 1960623 Sep 20, 2024
27 checks passed
@atrigila atrigila deleted the bump_mirtop branch September 20, 2024 14:08
herpov pushed a commit to herpov/modules that referenced this pull request Oct 2, 2024
@atrigila
Update mirtop version (nf-core#6663)
99b9fe6 
* update mirtop to 0.4.28

* add prefix to gff outputs

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@kpadm kpadm Awaiting requested review from kpadm kpadm was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atrigila @apeltzer