Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bcftools stubs to behave like program #6666

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fellen31
Copy link
Contributor

@fellen31 fellen31 commented Sep 19, 2024

This PR fixes issues where the stubs doesn't behave like the program would.

I.e. running bcftools with --output-type u/b --write-index=tbi, it still outputs a csi index, but were outputting a tbi index in the stubs:

  • --output-type v --write-index=tbi - error
  • --output-type v --write-index=csi - error
  • --output-type z --write-index=tbi - tbi index
  • --output-type z --write-index=csi - csi index
  • --output-type u --write-index=tbi - csi index <- note
  • --output-type u --write-index=csi - csi index
  • --output-type b --write-index=tbi - csi index <- note
  • --output-type b --write-index=csi - csi index

It takes the custom function added for bcftools csq in #6605, together with a similar function for the index, and applies it to the applicable modules.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant