Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate init #8

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Validate init #8

wants to merge 1 commit into from

Conversation

AlexMouton
Copy link
Contributor

No description provided.

@AlexMouton AlexMouton marked this pull request as draft January 16, 2025 23:33
@AlexMouton
ValidateInit
5b8122a 
Summary:

Test Plan:

***
Fix FieldVector makeStore to return Invalid for Invalid part, not Busy.

***
Add Init state propogation to FieldVector(Product)
@AlexMouton
Copy link
Contributor Author

AlexMouton commented Jan 17, 2025 •
edited
Loading

@KateChanthakaew try this one for validateInit.
There is something causing the "dyn" stream to emit a first "Dirty" frame that i havnt tracked down, but i worked around it in UseField using skip(1) for now. I want to check that the skip isnt making me miss a good value somewhere but it gets the point across

@cid8600 cid8600 self-requested a review January 17, 2025 00:37
@cid8600
Copy link
Contributor

cid8600 commented Jan 17, 2025

@KateChanthakaew try this one for validateInit. There is something causing the "dyn" stream to emit a first "Dirty" frame that i havnt tracked down, but i worked around it in UseField using skip(1) for now. I want to check that the skip isnt making me miss a good value somewhere but it gets the point across

@AlexMouton I'm working on rebasing our stack onto the last merge. Might take me a day or two. I am removing the "validateInit" like we had in the last PR. Just in terms of rebasing, i'll wait to merge any further changes like this branch until the reabse is complete. Then will need to sweep through the inits again. Shouldn't be too hard after this first major haul. FYI, @KateChanthakaew had restarted a rebase branch with the new actions pattern, which is helping me reference changes on my new effort, but I am starting over with a clean branch from our current develop. Not sure if there's a "pair code to make it faster" approach here, but just try not to change the patterns too much or will cause more drastic frustrations. lol.

Cheers.

@AlexMouton
Copy link
Contributor Author

AlexMouton commented Jan 17, 2025 •
edited
Loading

@cid8600 it might be easier to start here and go back to beta.5 if it doesnt work but Im stepping away. Can pair if that helps too

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cid8600 cid8600 Awaiting requested review from cid8600

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexMouton @cid8600