Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually add the privacy manifest to app resource bundle #2156

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

onevcat
Copy link
Owner

@onevcat onevcat commented Oct 27, 2023

This allows Xcode to generate read and generate the report based on Kingfisher's privacy manifest

Although for now, it only reads the "collecting data" section and Kingfisher does not has one, so there should be no actual affect to the app project. But I can verify the relate file are already under the correct place and be checked by Xcode 15. So in future, if Xcode decides to also generate the report for NSPrivacyAccessedAPITypes one day, there should be no additional work required in Kingfisher side.

Ref: #2122 #2155

@onevcat onevcat merged commit f59cf4c into master Oct 27, 2023
8 checks passed
@onevcat onevcat deleted the fix/manifest-resource branch October 27, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant