Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Snapshot _status API to return correct status for partial snapshots (#12812) #13260

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

aggarwalShivani
Copy link
Contributor

@aggarwalShivani aggarwalShivani commented Apr 17, 2024

Description

Backporting #12812 to 2.x branch.

Related Issues

Resolves #7952

Check List

  • New functionality includes testing.
    • All tests pass
  • ~[ ] New functionality has been documented. ~
    • [ ] New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for 328c0bb: SUCCESS

Copy link
Contributor

❌ Gradle check result for 20a9a5b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for a1323f3: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.15%. Comparing base (0dd892c) to head (a1323f3).
Report is 151 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/cluster/SnapshotsInProgress.java 50.00% 2 Missing and 1 partial ⚠️
...apshots/status/TransportSnapshotsStatusAction.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13260      +/-   ##
============================================
- Coverage     71.28%   71.15%   -0.13%     
- Complexity    60145    60615     +470     
============================================
  Files          4957     5004      +47     
  Lines        282799   285411    +2612     
  Branches      41409    41729     +320     
============================================
+ Hits         201591   203083    +1492     
- Misses        64189    65210    +1021     
- Partials      17019    17118      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aggarwalShivani
Copy link
Contributor Author

❕ Gradle check result for a1323f3: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Existing flaky issue ->
MixedClusterClientYamlTestSuiteIT.test() #2440

@reta reta merged commit 5aa165e into opensearch-project:2.x Apr 17, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed framework good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants