Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Allow skipping hot reload dn validation #4839

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c8cacf1 from #4752.

Signed-off-by: Paris Larkins <[email protected]>
Signed-off-by: Paris Larkins <[email protected]>
(cherry picked from commit c8cacf1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997
RyanL1997 previously approved these changes Oct 23, 2024
derek-ho
derek-ho previously approved these changes Oct 23, 2024
@cwperks cwperks dismissed stale reviews from derek-ho and RyanL1997 via 8397c41 October 28, 2024 15:44
@cwperks
Copy link
Member

cwperks commented Oct 28, 2024

Pushed the commit from #4841 to this PR

@willyborankin willyborankin merged commit 832753e into 2.x Oct 28, 2024
87 checks passed
@willyborankin willyborankin deleted the backport/backport-4752-to-2.x branch October 28, 2024 16:06
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2024
Signed-off-by: Paris Larkins <[email protected]>
Signed-off-by: Paris Larkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Craig Perkins <[email protected]>
(cherry picked from commit 832753e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.87%. Comparing base (000b084) to head (8397c41).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ensearch/security/ssl/DefaultSecurityKeyStore.java 55.55% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4839      +/-   ##
==========================================
+ Coverage   63.85%   63.87%   +0.02%     
==========================================
  Files         330      330              
  Lines       23091    23104      +13     
  Branches     3741     3742       +1     
==========================================
+ Hits        14744    14758      +14     
+ Misses       6516     6515       -1     
  Partials     1831     1831              
Files with missing lines Coverage Δ
...arch/security/ssl/OpenSearchSecuritySSLPlugin.java 87.24% <100.00%> (+0.21%) ⬆️
...org/opensearch/security/ssl/SslContextHandler.java 98.61% <100.00%> (+0.01%) ⬆️
.../opensearch/security/ssl/config/SslParameters.java 73.61% <100.00%> (+1.55%) ⬆️
...ensearch/security/ssl/util/SSLConfigConstants.java 79.16% <ø> (ø)
...ensearch/security/ssl/DefaultSecurityKeyStore.java 31.48% <55.55%> (+0.52%) ⬆️

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants