-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt disable dn verification on cert reload changes to SSL refactor #4841
Adapt disable dn verification on cert reload changes to SSL refactor #4841
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4841 +/- ##
==========================================
+ Coverage 69.82% 69.90% +0.08%
==========================================
Files 320 320
Lines 21661 21674 +13
Branches 3456 3457 +1
==========================================
+ Hits 15124 15151 +27
+ Misses 4742 4730 -12
+ Partials 1795 1793 -2
|
src/main/java/org/opensearch/security/ssl/SslContextHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4841-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2e0e64f213b85098873e60eb44d133da414dd1a7
# Push it to GitHub
git push --set-upstream origin backport/backport-4841-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
This PR and #4839 need to be backported together. |
…4841) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 2e0e64f)
Description
Adapts #4752 to the changes introduced in #4671.
Opening this up in Draft initially while additional testing is performed.
I also opened a revert PR as well to solicit feedback from maintainers on which direction we should take to fix the CI failures.
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.