Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSDOCS#12841] Observability metrics correlation for ShiftStack #86741

Merged
merged 1 commit into from
Feb 14, 2025
Merged

[OSDOCS#12841] Observability metrics correlation for ShiftStack #86741

merged 1 commit into from
Feb 14, 2025

Conversation

maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Jan 6, 2025 •
edited
Loading

Version(s): 4.18

Issue: OSDOCS-12841

Link to docs preview: https://86741--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/shiftstack-prometheus-configuration.html

QE review:

  • QE has approved this change.

TODOs:

  • Be extra paranoid about cluster qualifiers/naming. Don't confuse the two.

@maxwelldb maxwelldb added this to the Planned for 4.18 GA milestone Jan 6, 2025
@maxwelldb maxwelldb self-assigned this Jan 6, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 6, 2025
@maxwelldb maxwelldb force-pushed the shiftstack-observability branch from b4b3736 to e5b3a48 Compare January 6, 2025 21:27
@maxwelldb maxwelldb changed the title [OSDOCS#10582] Observability metrics correlation for ShiftStack [OSDOCS#12841] Observability metrics correlation for ShiftStack Jan 6, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 6, 2025 •
edited
Loading

🤖 Fri Feb 14 13:50:42 - Prow CI generated the docs preview:
https://86741--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@maxwelldb maxwelldb force-pushed the shiftstack-observability branch from b33ea0e to 5603ac1 Compare January 7, 2025 14:03
@pierreprinetti
Copy link
Member

/cc mandre

@openshift-ci openshift-ci bot requested a review from mandre January 7, 2025 14:39
@maxwelldb
Copy link
Contributor Author

@mandre @pierreprinetti Any thoughts on this?

pierreprinetti
pierreprinetti reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@pierreprinetti pierreprinetti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making sense of our upstream docs. It's crazy how better docs sound when they are written in actual English.

I have left several suggestions. Please don't take them as verbatim as they look; I just want to be sure you understand the concept so that you can translate it again to your language.

Thank you for your patience; the beginning of my year has been dense.

mandre
mandre reviewed Jan 20, 2025
View reviewed changes
modules/monitoring-configuring-shiftstack-scraping.adoc Outdated

// TODO: Is this RHOSO only?

You can open the federation endpoint of a cluster to make metrics available to a Red Hat OpenStack Services on OpenShift (RHOSO) cluster to practice pull-based monitoring.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make it clear this is an alternative to the above method of sending metrics to an external Prometheus server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't hurt.

@maxwelldb maxwelldb force-pushed the shiftstack-observability branch 2 times, most recently from b10c36c to c89f08c Compare January 28, 2025 17:17
@maxwelldb
Copy link
Contributor Author

@mandre @pierreprinetti Any thoughts on this?

@pierreprinetti
Copy link
Member

I believe I answered all your open questions.

@maxwelldb maxwelldb force-pushed the shiftstack-observability branch from 866d0a1 to 696aeef Compare February 7, 2025 14:57
@maxwelldb maxwelldb requested a review from eurijon February 7, 2025 15:17
@maxwelldb
Copy link
Contributor Author

I think it might be good to start getting QE input on this given time remaining until freeze. @eurijon

I don't think there are remaining dev review items to address, but LMK if I'm wrong. @mandre @pierreprinetti

eurijon
eurijon reviewed Feb 12, 2025
View reviewed changes
Copy link

@eurijon eurijon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @maxwelldb I added some comments and suggestions. Thanks for preparing this docs change!

@maxwelldb maxwelldb requested a review from eurijon February 12, 2025 16:50
@maxwelldb
Copy link
Contributor Author

@eurijon I think I addressed everything. LMK what you think.

@maxwelldb maxwelldb requested a review from eurijon February 13, 2025 13:28
@maxwelldb
Copy link
Contributor Author

@eurijon Thanks! Updated.

@eurijon
Copy link

eurijon commented Feb 13, 2025

Looks good to me @maxwelldb , thank you!

@maxwelldb
Copy link
Contributor Author

@eurijon Thank you!

@maxwelldb maxwelldb force-pushed the shiftstack-observability branch from 7a08722 to 3a77b88 Compare February 13, 2025 15:31
@maxwelldb
Copy link
Contributor Author

/cherry-pick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@maxwelldb: once the present PR merges, I will cherry-pick it on top of enterprise-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 13, 2025
maxwelldb
maxwelldb commented Feb 13, 2025
View reviewed changes
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 13, 2025
@lpettyjo lpettyjo self-requested a review February 13, 2025 23:39
lpettyjo
lpettyjo reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 14, 2025
@maxwelldb maxwelldb force-pushed the shiftstack-observability branch from e71d8a2 to ee24fb0 Compare February 14, 2025 13:29
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 14, 2025

@maxwelldb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maxwelldb maxwelldb merged commit fc302c0 into openshift:main Feb 14, 2025
2 checks passed
@maxwelldb maxwelldb deleted the shiftstack-observability branch February 14, 2025 14:12
@openshift-cherrypick-robot
Copy link

@maxwelldb: new pull request created: #88637

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 14, 2025
Merged
@maxwelldb maxwelldb mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpettyjo lpettyjo lpettyjo left review comments

@mandre mandre Awaiting requested review from mandre

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

@eurijon eurijon Awaiting requested review from eurijon

Assignees

@maxwelldb maxwelldb

Labels
branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.18 GA
Development

Successfully merging this pull request may close these issues.
7 participants
@maxwelldb @ocpdocs-previewbot @pierreprinetti @eurijon @openshift-cherrypick-robot @mandre @lpettyjo