fix(input): [input] fix textarea disabled style error

[zzcr]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features
  • Introduced a new Vue component demonstrating two disabled input fields.
  • Added a demo configuration for the disabled input state, enhancing usability.
• Bug Fixes
  • Improved visual consistency of the textarea component in its disabled state.
• Tests
  • Implemented a test case to verify the disabled state of input elements.

[coderabbitai]

Walkthrough

This pull request introduces a new Vue component that demonstrates disabled input fields using the tiny-input component from the @opentiny/vue library. It includes a corresponding test file to verify the disabled state of these inputs, as well as updates to related styles and demo configurations to enhance the visual representation and usability of the disabled inputs.

Changes

File Path	Change Summary
examples/sites/demos/pc/app/input/disabled-composition-api.vue, examples/sites/demos/pc/app/input/disabled.vue	Added Vue components showcasing two disabled input fields with tiny-input, including templates, scripts, and scoped styles.
examples/sites/demos/pc/app/input/disabled.spec.ts	Introduced a Playwright test to verify the disabled state of input elements on a specific page.
examples/sites/demos/pc/app/input/webdoc/input.js	Added a demo configuration for a disabled input state, including localized names and descriptions, and referencing the new Vue component.
packages/theme/src/textarea/index.less	Adjusted styles for the textarea component, including width calculations for pseudo-elements and background color properties for the disabled state.

Possibly related PRs

• fix(input): [input] fix textarea x-design style #2076: Modifies the textarea styles, potentially relevant to the disabled input fields introduced in this PR.
• feat(button): [button] Adapting to the SMB theme #2120: Adapts the button component to the SMB theme, which could interact with the new input fields.
• feat(checkbox): [checkbox] Adapting to the SMB theme #2130: Introduces changes to the checkbox component, possibly relating to the input fields.
• feat: [input] add new vars less #2128: Adds new LESS variables that could impact the styling of the new input fields.

Suggested labels

bug

Suggested reviewers

• kagol

Poem

In a meadow bright and wide,
Inputs rest, their states denied.
With a tiny touch, they gleam,
Disabled fields, a quiet dream.
Hop along, let changes flow,
In the code, new wonders grow! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

examples/sites/demos/pc/app/input/disabled-composition-api.vue (2)

1-6: Consider using separate variables for the text input and textarea.

If the text input and textarea are meant to capture different values, it would be better to bind them to separate variables instead of using the same input variable for both.

Provide more descriptive placeholders.

The current placeholders "input" and "textarea" are generic. Consider providing more descriptive placeholders to guide the user better, such as "Enter your name" or "Provide a description".

---

15-23: Consider using a more flexible unit for the width.

Instead of using a hardcoded pixel value for the width of demo-input, consider using a more flexible unit, such as percentages or rem, to accommodate different screen sizes and ensure responsiveness.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 577d509 and ecf3e29.

Files selected for processing (5)

• examples/sites/demos/pc/app/input/disabled-composition-api.vue (1 hunks)
• examples/sites/demos/pc/app/input/disabled.spec.ts (1 hunks)
• examples/sites/demos/pc/app/input/disabled.vue (1 hunks)
• examples/sites/demos/pc/app/input/webdoc/input.js (1 hunks)
• packages/theme/src/textarea/index.less (4 hunks)

Additional comments not posted (11)

examples/sites/demos/pc/app/input/disabled.spec.ts (4)

1-2: LGTM!

The imports are correct and necessary for writing Playwright tests.

---

3-4: LGTM!

The test setup is correct and follows best practices by setting up an event listener for page errors.

---

5-8: LGTM!

The page navigation and element locators are correct and reliable.

---

9-11: LGTM!

The assertions correctly verify that the input elements have the disabled attribute set, ensuring that they are disabled as expected.

examples/sites/demos/pc/app/input/disabled-composition-api.vue (1)

8-13: LGTM!

The script section correctly imports the necessary dependencies and defines the reactive variable input.

examples/sites/demos/pc/app/input/disabled.vue (1)

1-31: LGTM!

The component is a valid Vue component that demonstrates the usage of disabled inputs using the tiny-input component. The component correctly imports and registers the Input component, initializes the input data property, binds the input data property to the v-model directive of the tiny-input components, applies the disabled attribute to the tiny-input components, and defines scoped styles to enhance the visual layout of the demo.

The component is a new addition to the codebase and does not affect any existing functionality. It serves as a good example of how to use the tiny-input component with the disabled attribute.

packages/theme/src/textarea/index.less (4)

33-33: LGTM!

The adjustment to the width calculation for the :before pseudo-element looks good. It should improve the alignment or spacing within the textarea component.

---

45-45: LGTM!

The adjustment to the width calculation for the :after pseudo-element looks good. It should improve the alignment or spacing within the textarea component.

---

66-72: LGTM!

The addition of background color properties to the :before and :after pseudo-elements in the disabled state improves the visual consistency of the textarea component. This change ensures that the pseudo-elements reflect the same background color as the textarea itself when it is disabled.

---

186-188: LGTM!

The formatting adjustment to correct the indentation of nested selectors in the .is-display-only class improves the readability of the code.

examples/sites/demos/pc/app/input/webdoc/input.js (1)

30-42: LGTM!

The new demo configuration object for the 'disabled' demo is correctly added to the demos array. It follows the existing structure and conventions, provides relevant information about the demo, and references the appropriate Vue component file.