AO3-6751 Fix "Relationships by Character" url for fandoms with periods

[emilyw046]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6751

Purpose

Ensures period in the fandom tag page for fandoms with periods is properly escaped in the URL. Changed fandom_path(@tag.name) to fandom_path(@tag) in the app/views/tags/shot.html.erb file on line 32

Testing Instructions

1. Go to https://archiveofourown.org/tags/Harry%20Potter%20-%20J*d*%20K*d*%20Rowling
2. Follow the 'Relationship tags in this fandom' link,
3. You should get a link that is properly escaped like this: https://archiveofourown.org/fandoms/Harry%20Potter%20-%20J*d*%20K*d*%20Rowling

Credit

Emily Wiegand (she/her)

[sarken]

Hi, Emily!

Thank you so much for this pull request. It looks pretty good to me, although it would be a good idea to add a Cucumber test so we notice if this breaks again in the future.

In the meantime, I've updated the Jira issue status to In Review so no one will mistakenly create a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! You can just reply here with the account name and we'll set up the permissions for you. (It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME).")

Thanks again for contributing! If you have any questions, you can contact us at [email protected].

[emilyw046]

Sure! I'll work on the Cucumber test soon. My Jira is under Emily Wiegand (email: [email protected]). Excited to contribute more!

[sarken]

It looks like you're not showing up in our User Management section, but no worries -- this happens sometimes! I'll send an invitation to the email you provided, which usually fixes things.

[sarken]

I was pretty sure we already had a test for this link and didn't need a new feature file, so I tracked the existing test down: it's in features/other_b/fandoms.feature (added in #4350). Could you move this test to that file instead? Then I think this will be all done!

[sarken]

Sorry, I missed the email telling me you had pushed this change -- it looks ready to me now! 🎉