Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6751 Fix "Relationships by Character" url for fandoms with periods #5061

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

AO3-6751 Fix "Relationships by Character" url for fandoms with periods #5061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63117a6
change fandom_path(@tag.name) to fandom_path(@tag)
emilyw046 Feb 12, 2025
3d1e05f
AO3-6751 Added cucumber test
emilyw046 Feb 26, 2025
1025bff
AO3-6751 Moved cucumber test to fandoms.feature
emilyw046 Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/tags/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
filter_works_link: link_to(t(".filter_works"), tag_works_path(@tag)),
filter_bookmarks_link: link_to(t(".filter_bookmarks"), tag_bookmarks_path(@tag))) %>
<% if @tag.is_a?(Fandom) %>
<%= t(".list_fandom_tags_html", fandom_relationship_tags_link: link_to(t(".fandom_relationship_tags"), fandom_path(@tag.name))) %>
<%= t(".list_fandom_tags_html", fandom_relationship_tags_link: link_to(t(".fandom_relationship_tags"), fandom_path(@tag))) %>
<% end %>
<% end %>
</p>
Expand Down
7 changes: 7 additions & 0 deletions features/other_b/fandoms.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,10 @@ Feature: There is a list of unassigned Fandoms
And I follow "Relationship tags in this fandom"
Then I should see "Ruby (Steven Universe)"
And I should see "Sapphire (Steven Universe)"

Scenario: Click on "Relationships by Character" on a fandom tag containing periods
Given a canonical fandom "Harry Potter - J. K. Rowling"
When I view the tag "Harry Potter - J. K. Rowling"
And I follow "Relationship tags in this fandom"
Then I should not see "The page you were looking for doesn't exist."
And I should see "Relationships by Character"
Loading