Add iPadOs device check to overlay continue button #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchoun
commented
Jan 29, 2024
Merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 7 7
Lines 152 152
Branches 35 35
=======================================
Hits 90 90
Misses 52 52
Partials 10 10 ☔ View full report in Codecov by Sentry. |
SancSalix
approved these changes
Feb 27, 2024
cgdibble
approved these changes
Feb 27, 2024
wsbrunson
approved these changes
Feb 28, 2024
elizabethmv
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our overlay currently will check for iOS when the continue message is clicked. If the device is an iOS device, it will display an alert and prompt the user to switch to the tab manually to reactivate the PayPal window.
However, Safari on iOS13 and up on an iPad device will return a user agent that looks like a MacOS desktop user agent and this alert is not displayed.
The proposed solution will cover this edge case and properly display the alert message.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Jira Ticket - LI-30263
Screenshots (if applicable)
Dependent Changes (if applicable)
Related PR from krakenjs/belter
Groups who should review (if applicable)
❤️ Thank you!