Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre issues #72

Closed
wants to merge 1 commit into from
Closed

Fix pre issues #72

wants to merge 1 commit into from

Conversation

jnvsor
Copy link
Collaborator

@jnvsor jnvsor commented Jan 15, 2016

Fixes #70

Far slower performance with blanklines enabled though.

dab26c8 blanklines is correct as far as browser output goes (Extra whitespace is only in markup, not rendered) and is a whopping twice as fast as this version. (And faster than current master too) so perhaps it would be a better idea to just reset to that and ignore the whitespace inconsistancies.

Also, this shines light on the fact we need a second benchmark for blanklines mode - I'll get to work on that now

@jnvsor
Copy link
Collaborator Author

jnvsor commented Jan 15, 2016

That's weird - the test passes on my machine.

At this point @penibelst it's becoming a right pain in the ass and I think we should go back to dab26c8 on the whitespace

@jnvsor
Copy link
Collaborator Author

jnvsor commented Jan 19, 2016

Closing this, as discussed in #70 I don't think the performance penalty is worth it. I'm going to revert to a simpler version and add another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant