Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move/rewrite some of the macOS and Unix install instructions #3763

Merged
merged 21 commits into from
Sep 24, 2024

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Sep 18, 2024

Trying to put more emphasis/information on how to install from packages (either from distributions or third parties) and for Unix, in particular, move the stuff about compiling from source down a level so new users don't get knocked in the face with it.

@jimwins
Copy link
Member Author

jimwins commented Sep 18, 2024

The 'DNF' section is based on the Debian one, but could certainly use review by someone who actually uses a DNF-based system, because that's not me. Also not sure if it should treat Yum and DNF like the Debian section does with apt and aptitude.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for tackling this long overdue update!

Unfortunately, I can't help much with the details about installing on non Windows systems. Hopefully, some others can provide useful comments.

install/unix/debian.xml Outdated Show resolved Hide resolved
install/unix/source.xml Outdated Show resolved Hide resolved
@jimwins jimwins marked this pull request as ready for review September 21, 2024 22:34
install/unix/debian.xml Show resolved Hide resolved
install/unix/dnf.xml Outdated Show resolved Hide resolved
install/unix/dnf.xml Outdated Show resolved Hide resolved
install/unix/dnf.xml Outdated Show resolved Hide resolved
install/unix/dnf.xml Outdated Show resolved Hide resolved
install/unix/source.xml Outdated Show resolved Hide resolved
install/unix/source.xml Outdated Show resolved Hide resolved
install/unix/source.xml Outdated Show resolved Hide resolved
install/unix/source.xml Outdated Show resolved Hide resolved
language-snippets.ent Outdated Show resolved Hide resolved
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more markup comments

install/macos/packages.xml Outdated Show resolved Hide resolved
install/unix/dnf.xml Outdated Show resolved Hide resolved
install/unix/dnf.xml Outdated Show resolved Hide resolved
install/unix/dnf.xml Outdated Show resolved Hide resolved
install/unix/dnf.xml Outdated Show resolved Hide resolved
install/unix/dnf.xml Outdated Show resolved Hide resolved
install/unix/index.xml Outdated Show resolved Hide resolved
install/unix/source.xml Outdated Show resolved Hide resolved
install/unix/source.xml Outdated Show resolved Hide resolved
install/unix/source.xml Outdated Show resolved Hide resolved
@jimwins
Copy link
Member Author

jimwins commented Sep 24, 2024

Instead of spamming a half-dozen "done!" comments, here's one to note that all of the feedback from @Girgias was addressed. The build fails now because I moved some entities into doc-base and that needs to land first.

Girgias pushed a commit to php/doc-base that referenced this pull request Sep 24, 2024
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final comment and LGTM.

Thanks for tackling this!

install/unix/source.xml Outdated Show resolved Hide resolved
@jimwins jimwins merged commit 4cb53ec into php:master Sep 24, 2024
2 checks passed
@jimwins jimwins deleted the clean-up-installation-instructions branch September 24, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants