Support building a shared php8embed.dll #17480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far only static php8embed.lib has been supported on Windows, while on POSIX the choice was up to the user. Now, `--enable-embed=shared` is also supported on Windows. For BC reasons we stick with static as default; the resulting embed library can be used like before. To avoid that snapshot builds now build a shared library, we add an exemption to confutils.js. To properly support a static and a shared library, respectively, we do the customary `__declspec` dance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far only static php8embed.lib has been supported on Windows, while on POSIX the choice was up to the user. Now,
--enable-embed=sharedis also supported on Windows.For BC reasons we stick with static as default; the resulting embed library can be used like before. To avoid that snapshot builds now build a shared library, we add an exemption to confutils.js.
To properly support a static and a shared library, respectively, we do the customary
__declspecdance.