Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building a shared php8embed.dll #17480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support building a shared php8embed.dll #17480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sapi/embed/config.w32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ ARG_ENABLE('embed', 'Embedded SAPI library', 'no');
var PHP_EMBED_PGO = false;

if (PHP_EMBED != "no") {
SAPI('embed', 'php_embed.c', 'php' + PHP_VERSION + 'embed.lib', '/DZEND_ENABLE_STATIC_TSRMLS_CACHE=1');
SAPI('embed', 'php_embed.c', 'php' + PHP_VERSION + 'embed.' + (PHP_EMBED_SHARED ? 'dll' : 'lib'), '/DZEND_ENABLE_STATIC_TSRMLS_CACHE=1');
if (PHP_EMBED_SHARED) {
ADD_FLAG("CFLAGS_EMBED", "/DPHP_EMBED_EXPORTS");
AC_DEFINE("PHP_EMBED_SHARED", 1, "Define to 1 if you have a shared embed SAPI.");
}
PHP_INSTALL_HEADERS("sapi/embed", "php_embed.h");
}
8 changes: 7 additions & 1 deletion sapi/embed/php_embed.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,13 @@
#ifndef PHP_WIN32
#define EMBED_SAPI_API SAPI_API
#else
#define EMBED_SAPI_API
# if defined(PHP_EMBED_EXPORTS)
# define EMBED_SAPI_API __declspec(dllexport)
# elif defined(PHP_EMBED_SHARED)
# define EMBED_SAPI_API __declspec(dllimport)
# else
# define EMBED_SAPI_API
# endif
#endif

#ifdef ZTS
Expand Down
2 changes: 1 addition & 1 deletion win32/build/confutils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ can be built that way. \
if (force) {
STDOUT.WriteLine("snapshot: forcing " + arg.optname + " on");
argval = "yes";
shared = true;
shared = arg.optname != "embed";
}
}

Expand Down
Loading