Block Machine: Handle case where number of rows is just enough #2070
+53
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
commented
Nov 11, 2024
georgwiese
changed the title
This was referenced Nov 11, 2024
|
Test fails |
leonardoalt
reviewed
Nov 11, 2024
| self.degree = compute_size_and_log( | ||
| &self.name, | ||
| // At this point, the still contains the dummy block, which will be removed below. | ||
| // Therefore, we subtract the block size here. |
There was a problem hiding this comment.
Hmm, so I think the hacky part is that the data has a block that will be removed later, right? Which was the case before this PR?
I tried refactoring it, but it's kinda complicated. LMK if you have a suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, we used to panic if the number of rows in a block machine was just enough to fit the needed number of blocks. This PR fixes it.