Setters and getters for trace IDs #967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D60267172 |
|
This pull request was exported from Phabricator. Differential Revision: D60267172 |
sanrise
added a commit
to sanrise/kineto
that referenced
this pull request
Jul 26, 2024
Summary: Pull Request resolved: pytorch#967 This commit moves the trace ID initialization logic to be inline with how ActivityProfilers interact with LoggerObservers by setting a default local trace ID when a profiler config does not contain a trace ID. The USTLoggerCollector, which is our internal LoggerObserver will record the trace ID for a given environment (which is a PID today) using the `setTraceID` method that all LoggerObservers must staisfy. Additionally any internal calls to read this trace ID, for example from our ManifoldChromeTrace logger, may use a special `getTraceID` method that ships with `USTLoggerCollector`. Group trace IDs are handled accordingly. Differential Revision: D60267172
sanrise
force-pushed
the
export-D60267172
branch
from
0a223b3
to
c3c9c74
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60267172 |
sanrise
added a commit
to sanrise/kineto
that referenced
this pull request
Jul 26, 2024
Summary: Pull Request resolved: pytorch#967 This commit moves the trace ID initialization logic to be inline with how ActivityProfilers interact with LoggerObservers by setting a default local trace ID when a profiler config does not contain a trace ID. The USTLoggerCollector, which is our internal LoggerObserver will record the trace ID for a given environment (which is a PID today) using the `setTraceID` method that all LoggerObservers must staisfy. Additionally any internal calls to read this trace ID, for example from our ManifoldChromeTrace logger, may use a special `getTraceID` method that ships with `USTLoggerCollector`. Group trace IDs are handled accordingly. Differential Revision: D60267172
sanrise
force-pushed
the
export-D60267172
branch
from
c3c9c74
to
9624e01
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60267172 |
sanrise
added a commit
to sanrise/kineto
that referenced
this pull request
Jul 26, 2024
Summary: Pull Request resolved: pytorch#967 This commit moves the trace ID initialization logic to be inline with how ActivityProfilers interact with LoggerObservers by setting a default local trace ID when a profiler config does not contain a trace ID. The USTLoggerCollector, which is our internal LoggerObserver will record the trace ID for a given environment (which is a PID today) using the `setTraceID` method that all LoggerObservers must staisfy. Additionally any internal calls to read this trace ID, for example from our ManifoldChromeTrace logger, may use a special `getTraceID` method that ships with `USTLoggerCollector`. Group trace IDs are handled accordingly. Differential Revision: D60267172
sanrise
force-pushed
the
export-D60267172
branch
from
9624e01
to
41a8948
Compare
Summary: Pull Request resolved: pytorch#967 This commit moves the trace ID initialization logic to be inline with how ActivityProfilers interact with LoggerObservers by setting a default local trace ID when a profiler config does not contain a trace ID. The USTLoggerCollector, which is our internal LoggerObserver will record the trace ID for a given environment (which is a PID today) using the `setTraceID` method that all LoggerObservers must staisfy. Additionally any internal calls to read this trace ID, for example from our ManifoldChromeTrace logger, may use a special `getTraceID` method that ships with `USTLoggerCollector`. Group trace IDs are handled accordingly. Differential Revision: D60267172
|
This pull request was exported from Phabricator. Differential Revision: D60267172 |
sanrise
force-pushed
the
export-D60267172
branch
from
41a8948
to
3ee82a3
Compare
aaronenyeshi
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit moves the trace ID initialization logic to be inline with how ActivityProfilers interact with LoggerObservers by setting a default local trace ID when a profiler config does not contain a trace ID.
The USTLoggerCollector, which is our internal LoggerObserver will record the trace ID for a given environment (which is a PID today) using the
setTraceIDmethod that all LoggerObservers must staisfy. Additionally any internal calls to read this trace ID, for example from our ManifoldChromeTrace logger, may use a specialgetTraceIDmethod that ships withUSTLoggerCollector.Group trace IDs are handled accordingly.
Differential Revision: D60267172