Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setters and getters for trace IDs #967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Setters and getters for trace IDs #967

wants to merge 1 commit into from

Commits on Jul 31, 2024

  1. Setters and getters for trace IDs (pytorch#967) 

    Summary:
Pull Request resolved: pytorch#967

This commit moves the trace ID initialization logic to be inline with how ActivityProfilers interact with LoggerObservers by setting a default local trace ID when a profiler config does not contain a trace ID.

The USTLoggerCollector, which is our internal LoggerObserver will record the trace ID for a given environment (which is a PID today) using the `setTraceID` method that all LoggerObservers must staisfy. Additionally any internal calls to read this trace ID, for example from our ManifoldChromeTrace logger, may use a special `getTraceID` method that ships with `USTLoggerCollector`.

Group trace IDs are handled accordingly.

Differential Revision: D60267172
    @sanrise @facebook-github-bot
    sanrise authored and facebook-github-bot committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3ee82a3 View commit details
    Browse the repository at this point in the history