Build Mac wheels in CI #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Closed
scotts
force-pushed
the
mac_wheels_ci
branch
5 times, most recently
from
65d2476 to
10dd8ca
Compare
atalman
pushed a commit
to pytorch/test-infra
that referenced
this pull request
Oct 1, 2024
This PR enable the build of M1 wheels to rely on `python -m build` instead of `python setup.py`. The default is still `python setup.py`. This is the same as #5071 and #5076 that were landed for linux wheels. We need this for torchcodec to support M1 wheels pytorch/torchcodec#230 CC @scotts @atalman
scotts
force-pushed
the
mac_wheels_ci
branch
9 times, most recently
from
7ae2cc3 to
1032dd1
Compare
atalman
reviewed
Oct 9, 2024
atalman
reviewed
Oct 9, 2024
atalman
reviewed
Oct 9, 2024
atalman
reviewed
Oct 9, 2024
NicolasHug
reviewed
Oct 23, 2024
NicolasHug
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
What a ride. Thank you so much @scotts for pushing through!
Nothing blocking from me, just nits and one Q
NicolasHug
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
What a ride. Thank you so much @scotts for pushing through!
Nothing blocking from me, just nits and one Q
ahmadsharif1
approved these changes
Oct 23, 2024
scotts
force-pushed
the
mac_wheels_ci
branch
4 times, most recently
from
cd96123 to
b78a737
Compare
scotts
force-pushed
the
mac_wheels_ci
branch
10 times, most recently
from
c3a7d00 to
af25dad
Compare
scotts
force-pushed
the
mac_wheels_ci
branch
2 times, most recently
from
dc2fd48 to
393d108
Compare
NicolasHug
added a commit
to NicolasHug/test-infra
that referenced
this pull request
Nov 18, 2024
This PR enable the build of M1 wheels to rely on `python -m build` instead of `python setup.py`. The default is still `python setup.py`. This is the same as pytorch#5071 and pytorch#5076 that were landed for linux wheels. We need this for torchcodec to support M1 wheels pytorch/torchcodec#230 CC @scotts @atalman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this summary was written a month after opening the PR. As evidenced by the commit history below, getting this in shape has been a journey. A summary of the actual changes we'll commit:
VLOGandLOG) from our C++ code. For reasons that we have not been able to fully explain, we get segfaults in those logging calls only when we ran from a Mac wheel. We do not segfault there when we build and test Mac from source, or in any situation with Linux. That might indicate a problem in PyTorch core. If we want logging back, we can decide how best to it then.