Unbreak CI by using C++17 code #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
scotts
approved these changes
Oct 16, 2024
scotts
reviewed
Oct 16, 2024
| @@ -168,7 +168,7 @@ void _add_video_stream( | |||
| if (device.has_value()) { | |||
| if (device.value() == "cpu") { | |||
| options.device = torch::Device(torch::kCPU); | |||
| } else if (device.value().starts_with("cuda")) { | |||
| } else if (device.value().rfind("cuda", 0) == 0) { // starts with "cuda" | |||
There was a problem hiding this comment.
Since rfind() starts from the end ("reverse find"), this is technically "ends with 'cuda'". See https://en.cppreference.com/w/cpp/string/basic_string/rfind.
There was a problem hiding this comment.
rfind with a pos argument of 0 -- rfind(*, 0) -- looks for a prefix
|
Approving and merging to unbreak CI. We can figure out later if it should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::string's starts_with method is c++20
So we use a different incantation that's C++17 compliant