Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak CI by using C++17 code #264

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Unbreak CI by using C++17 code #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/torchcodec/decoders/_core/VideoDecoderOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ void _add_video_stream(
if (device.has_value()) {
if (device.value() == "cpu") {
options.device = torch::Device(torch::kCPU);
} else if (device.value().starts_with("cuda")) {
} else if (device.value().rfind("cuda", 0) == 0) { // starts with "cuda"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since rfind() starts from the end ("reverse find"), this is technically "ends with 'cuda'". See https://en.cppreference.com/w/cpp/string/basic_string/rfind.

Copy link
Contributor Author

@ahmadsharif1 ahmadsharif1 Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rfind with a pos argument of 0 -- rfind(*, 0) -- looks for a prefix

std::string deviceStr(device.value());
options.device = torch::Device(deviceStr);
} else {
Expand Down
Loading