[Core][aDAG] Set buffer size to 1 for regression #47639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
changed the title
8 tasks
ruisearch42
approved these changes
Sep 16, 2024
| @@ -661,7 +661,7 @@ def __init__( | |||
| # We conservatively set num_shm_buffers to _max_inflight_executions. | |||
| # It means that the DAG can be underutilized, but it guarantees there's | |||
| # no false positive timeouts. | |||
| num_shm_buffers=self._max_inflight_executions, | |||
| num_shm_buffers=1, | |||
There was a problem hiding this comment.
Can you update the comment above and add a TODO?
There was a problem hiding this comment.
I will fix this this week, so it may be okay?
There was a problem hiding this comment.
Yes, feel free to merge first if urgent.
kevin85421
approved these changes
Sep 16, 2024
|
It is in my sprint task. |
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Sep 17, 2024
There's a regression with buffer size 10. I am going to investigate but I will revert it to buffer size 1 for now until further investigation. With buffer size 1, regression seems to be gone https://buildkite.com/ray-project/release/builds/22594#0191ed4b-5477-45ff-be9e-6e098b5fbb3c. probably some sort of contention or sth like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There's a regression with buffer size 10. I am going to investigate but I will revert it to buffer size 1 for now until further investigation.
With buffer size 1, regression seems to be gone https://buildkite.com/ray-project/release/builds/22594#0191ed4b-5477-45ff-be9e-6e098b5fbb3c. probably some sort of contention or sth like that
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.