Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the dummy app uses the same template as real apps. #3180

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

parndt
Copy link
Member

@parndt parndt commented May 17, 2016

This Fails

This is work I was doing last July, but it still seems like a good thing to work on. I wasn't happy that the dummy app used a different template than the one we ask people to install with because this way we can implicitly test that template's always correct.

It needs rebasing and validating.

# Refinery does not necessarily expect action_mailer to be available as
# we may not always require it (currently only the authentication extension).
# Rails, however, will optimistically place config entries for action_mailer.
current_mailer_config = mailer_config(env_file)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mailer stuff should be done by refinerycms-inquiries. The core doesn't send mail.

Maybe this whole thing shouldn't even be our concern?

@bricesanchez
Copy link
Member

Hi @parndt ! Could you update your PR?

@bricesanchez
Copy link
Member

I've tried to fix specs on this PR but i'm not sure if my commits helps. Please, could you check if you can fix specs @parndt ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants