Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the dummy app uses the same template as real apps. #3180

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Ensure the dummy app uses the same template as real apps. #3180

wants to merge 8 commits into from

Commits on Mar 12, 2018

  1. Ensure the dummy app uses the same template as real apps.

    @parndt
    parndt committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    5bb2fb5 View commit details
    Browse the repository at this point in the history

  2. Remove assets.compile = true

    @parndt
    parndt committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    4301b12 View commit details
    Browse the repository at this point in the history

  3. Opt in to fewer than rails/all

    @parndt
    parndt committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    073ca64 View commit details
    Browse the repository at this point in the history

  4. Ignore load_error variable

    @parndt
    parndt committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    2e8a1c3 View commit details
    Browse the repository at this point in the history

  5. The dummy generator fails without activejob 🐊

    @parndt
    parndt committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    fe79c2d View commit details
    Browse the repository at this point in the history

  6. yes to all generator questions

    @parndt
    parndt committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    b187ee2 View commit details
    Browse the repository at this point in the history

  7. Rename skip_migrate to skip_migrations 

    This should fix pages fails on MySQL.

I suspect, "skip_migrate" is not the right option name, "skip_migration" is also used to skip the seeds in: https://github.com/refinery/refinerycms/blob/10e63784613682db8f8b094878f60a01413b39f6/core/lib/generators/refinery/cms/cms_generator.rb#L269
    @bricesanchez @parndt
    bricesanchez authored and parndt committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    249cd9e View commit details
    Browse the repository at this point in the history

  8. Add skip-seeds arg to Refinery::CmsGenerator

    @bricesanchez @parndt
    bricesanchez authored and parndt committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    c3cac10 View commit details
    Browse the repository at this point in the history