io: Allow implicit conversion from vector<pair<A<B> > to map<A,B> #17591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 4d 21h 26m 29s ⏱️ Results for commit 4d6101a. ♻️ This comment has been updated with latest results. |
jblomer
approved these changes
Feb 2, 2025
For once, it was the reverse and this PR is fixing an issue that was (re)discovered by the test reorganization and subsequent enabling of a test that had been forgotten. |
|
The Windows failure is 'real' and was not noticed before as the test was not run on Windows (due to being part of a gmake tests) |
pcanal
commented
Feb 6, 2025
pcanal
force-pushed
the
master-split-roottest-make
branch
from
ba9c270 to
dde6d28
Compare
This avoid the risk of applying the dereference twice.
pcanal
force-pushed
the
master-split-roottest-make
branch
from
dde6d28 to
9f64056
Compare
linev
requested changes
Feb 7, 2025
This reverts commit 459246d.
Both this function expect the value of a data member which is a pointer rather than its address: ``` TString TBufferJSON::JsonWriteMember(const void *ptr, TDataMember *member, TClass *memberClass, Int_t arraylen) TString TBufferJSON::ConvertToJSON(const void *ptr, TDataMember *member, Int_t compact, Int_t arraylen) ```
|
There was a timeout in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The roottest companion PR is root-project/roottest#1255