Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split several make roottest directories. #1255

Merged
merged 14 commits into from
Feb 8, 2025

Conversation

pcanal
Copy link
Member

@pcanal pcanal commented Jan 31, 2025

Split:

  • roottest-io-evolution subdirectories
  • roottest-io-evolution itself in 3 parts
    • numerical_evolution
    • stl_evolution
    • the rest
  • roottest-root-io-json
  • roottest-root-io-datamodelevolution
  • roottest-root-io-newClassDef

The ROOT companion PR fix an issue that made roottest-root-io-evolution-stl_evolution

After this update, the top 15 roottest-.*-make time consumers are:

115/123 Test #1824: roottest-root-io-newstl-make ...........................   Passed  609.78 sec
114/123 Test #2369: roottest-root-tree-addresses-make ......................   Passed  398.07 sec
112/123 Test #2450: roottest-root-treeproxy-make ...........................   Passed  305.51 sec
113/123 Test #1728: roottest-root-io-evolution-numerical_conversions-make ..   Passed  263.90 sec
111/123 Test #1722: roottest-root-io-evolution-make ........................   Passed  260.71 sec
110/123 Test #2395: roottest-root-tree-evolution-make ......................   Passed  228.12 sec
107/123 Test #2430: roottest-root-treeformula-array-make ...................   Passed  139.64 sec
106/123 Test #2372: roottest-root-tree-branches-make .......................   Passed  137.46 sec
109/123 Test #1733: roottest-root-io-evolution-versions-make ...............   Passed  135.68 sec
104/123 Test #1831: roottest-root-io-rootcint-make .........................   Passed  134.20 sec
101/123 Test #1936: roottest-root-io-vararyobj-make ........................   Passed  122.92 sec
 97/123 Test #1830: roottest-root-io-references-make .......................   Passed  118.27 sec
 94/123 Test #2408: roottest-root-tree-friend-make .........................   Passed  111.25 sec
 91/123 Test #2442: roottest-root-treeformula-parse-make ...................   Passed  108.10 sec
105/123 Test #2416: roottest-root-tree-reader-make .........................   Passed   93.79 sec

Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to follow all macros (or the Makefiles), but this looks like this will run the tests in parallel.

And like the other directories, 'distclean' does not delete that library
The utils library is used/shared by many Makefiles which will trigger its creation/update.
If the Makefile are run in parallel this can lead to spurrious failures.
@pcanal pcanal merged commit d391df3 into root-project:master Feb 8, 2025
@pcanal pcanal deleted the master-split-roottest-make branch February 8, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants