-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split several make roottest directories. #1255
Merged
pcanal
merged 14 commits into
root-project:master
from
pcanal:master-split-roottest-make
Feb 8, 2025
Merged
Split several make roottest directories. #1255
pcanal
merged 14 commits into
root-project:master
from
pcanal:master-split-roottest-make
Feb 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: we now enable the stl numerical conversion tests. They previous were broken but a recent commit allowed the conversion from vector<pair<a,b>> to map<a,b> and now the test works.
hageboeck
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't manage to follow all macros (or the Makefiles), but this looks like this will run the tests in parallel.
And like the other directories, 'distclean' does not delete that library
The utils library is used/shared by many Makefiles which will trigger its creation/update. If the Makefile are run in parallel this can lead to spurrious failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split:
The ROOT companion PR fix an issue that made roottest-root-io-evolution-stl_evolution
After this update, the top 15
roottest-.*-make
time consumers are: