Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get pose from camera params using opencv2 #174

Open
wants to merge 2 commits into
base: melodic-devel
Choose a base branch
from

Conversation

raphaelmemmesheimer
Copy link

I think there were some leftovers from the past. I changed the fromCameraParams function to work with opencv2.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking to modernize this. However I have to ask if this is backwards compatible. In particular a CvMat and a Numpy array I believe are not interchangeable. So this would be a noticeable change in API which would break any current users. To that end I might suggest considering creating a new related function. However in general this whole repository is generally deprecated in favor of geometry2. So to that end I'd suggest looking to contribute this similar functionality to tf2_kdl.

https://github.com/ros/geometry2/blob/melodic-devel/tf2_kdl/src/tf2_kdl/tf2_kdl.py

The one other caveat is that that doesn't have an opencv dependency so there might be a better place for it such as image_geometry. Though that doesn't have a dependency on kdl so this functionality falls somewhere in between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants