Move from Azure to AWS S3 for blob storage #5023
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwaiid
reviewed
Feb 24, 2025
| @@ -6,18 +8,12 @@ task :backup_db_rds => :environment do | |||
| current_time = Time.current.strftime("%Y%m%d%H%M%S") | |||
|
|
|||
| logger.info("Copying the database...") | |||
| backup_filename = "#{current_time}.rds.dump" | |||
| backup_filename = "#{Rails.env}-#{current_time}.rds.dump" | |||
awwaiid
reviewed
Feb 24, 2025
| storage_account_name: account_name, | ||
| storage_access_key: account_key | ||
| ) | ||
| client = Aws::S3::Client.new(region: 'us-east-2') |
There was a problem hiding this comment.
Is this the same as
client = ActiveStorage::Blob.services.fetch(:amazon)
There was a problem hiding this comment.
Basically. In this case I'm going straight to the client rather than doing it in a roundabout way through ActiveStorage.
|
Is CORS enabled on S3? Will be needed for direct uploads, introduced here: #4937 |
|
Yep, it should be! |
awwaiid
reviewed
Feb 26, 2025
| class MoveAzureBlobsToS3 < ActiveRecord::Migration[7.2] | ||
| # https://stackoverflow.com/questions/71699789/activestorage-transfer-all-assets-from-one-bucket-to-another-bucket | ||
| def up | ||
| return unless Rails.env.staging? |
There was a problem hiding this comment.
Ah, so only run this migration in staging. I see.
|
We'll let @cielf merge as part of a controlled staging validation (upload files, merge this, see that they're still there, upload more files) |
|
I was hoping to get to this today but life interfered. Hopefully Friday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
amazonstorage provider. I've set up blob storage buckets for both production and staging.amazonfor staging only for now.My suggestion for testing:
Once testing is complete, this branch is safe to merge, and we can put in a further PR that will apply these changes to prod.