Fixed min.cells.group issue in FindConservedMarkers()
#8910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FindConservedMarkers
throws an error on too few cells even when parametermin.cells.group
is lower than number of cells.Distinct but related PR: #5079
The current behavior of FindConservedMarkers is the following:
If a group has greater than number of
min.cells.group
but less than 3 (the default formin.cells.group
in functionFindMarkers()
) you get an error from ValidateCellGroups within FindMarkers because it is less than the threshold.This is because the parameter
min.cells.group
, when used inFindConservedMarkers
, was not passed down to FindMarkersThe error is as follows:
Implementation
I added the parameter to min.cells.group the FindMarkers() function that is run within FindConservedMarkers() so that that setting is passed down