-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy r defs #99
Lazy r defs #99
Conversation
now as well the |
"For the R function [str](https://www.rdocumentation.org/packages/utils/versions/3.6.1/topics/str), we capture the standard output and return the corresponding string." | ||
(r "function(x) capture.output(str(x))") ) | ||
|
||
(defn println-captured-str[x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this did before, so could not test it.
How is it suppoed to be used ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember precisely. Some functions print something and it would be great to have the result as a string. But it's a guess (I need to remember this topic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for example summary()
prints to stdout
I think I made all "lazy", keeping full functionality. |
Wow! You've made a great job! Thanks. |
src/clojisr/v1/util.clj
Outdated
@@ -144,7 +144,6 @@ | |||
(.close socket) | |||
(.getLocalPort socket))) | |||
|
|||
;; symbol, string, how to process parameters (all or butlast) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment deleted by mistake
Where is the code which defines Its mentioned in CHANGELOG, but cannot find it |
added `rcolon` for consistency
I don't remember precisely, maybe it was done in |
I'll review this today. |
@genmeblog |
Oh, thanks for the reminder. I believe I've tested it locally and everything worked. But it was 4 months ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok
is this ready to be merged ? |
got the simple unary / binary functions "r_xxx" working