BUGFIX: Fix optional parameter handling in deserializer #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expected slots when parameters in between are missing
mficzel
changed the title
mficzel
force-pushed
the
bugfix/fixOtionalParametersHandling
branch
2 times, most recently
from
1b50e50
to
37761e9
Compare
…expected slots when parameters in between are missing
mficzel
force-pushed
the
bugfix/fixOtionalParametersHandling
branch
from
80fdc28
to
98cc972
Compare
…nd not by position.
mficzel
changed the title
mficzel
changed the title
mwuest
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema denormalizer passed arguments by order and not by name which caused problems when an optional parameter in between was missing.
The fix adjusts the denormalizer to pass arguments by name to value objects