Pr graduation #68
Merged
Pr graduation #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwryankrattiger
force-pushed
the
pr-graduation
branch
from
d595dc1 to
b05321a
Compare
kwryankrattiger
force-pushed
the
pr-graduation
branch
8 times, most recently
from
ffb872f to
9d26e15
Compare
3 tasks
kwryankrattiger
force-pushed
the
pr-graduation
branch
4 times, most recently
from
811948c to
759ba02
Compare
scottwittenburg
requested changes
Nov 8, 2022
There was a problem hiding this comment.
Thanks @kwryankrattiger, this looks like a lot of work, but is coming along nicely. I have added what I think are mostly questions, but also some requests. Hopefully you can straighten me out where I'm not getting it.
Also, a blanket request to apply to the change as a whole: Can you add docstrings to the new methods and describe the behavior of the methods, as well as expected inputs, and outputs?
Also, before it's all over, you're going to need to run black on your changes to get this to pass the style check. Just install it with pip and run black . from the top level of the repo, or maybe from the spackbot directory, I forget.
kwryankrattiger
force-pushed
the
pr-graduation
branch
3 times, most recently
from
8ae3dd8 to
a2569ac
Compare
New Queues * Remove queue singleton to make it easier to use multiple work queues * Update worker entry point to select worker queue by WORKER_TASK_QUEUE Use s3 URL instead of strings * Fixes inconsistency if xxx_base_url contains a prefix component * Makes working with s3 resources consistent everywhere
When a PR is closed by a merge: * Copy the PR mirror to the graduated binaries mirror * Prune duplicates that have already been updated in the "develop" mirror * Reindex the graduated binaries mirror * Delete the PR mirror When a PR is closed, but not merged: * Delete the PR mirror This change removes the need for a sync script based cleaning of PR binary mirrors.
kwryankrattiger
force-pushed
the
pr-graduation
branch
from
a2569ac to
7ee0842
Compare
scottwittenburg
approved these changes
Nov 11, 2022
kwryankrattiger
force-pushed
the
pr-graduation
branch
from
7eb91c7 to
0af4fa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@scottwittenburg
Reviving #45