fix: correctly visit elements that may match :has() during pruning #15207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b41004a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
7nik
commented
Feb 4, 2025
| @@ -234,7 +236,7 @@ function apply_combinator(relative_selector, parent_selectors, rule, node) { | |||
|
|
|||
| case '+': | |||
| case '~': { | |||
| const siblings = get_possible_element_siblings(node, name === '+'); | |||
| const siblings = get_possible_element_preceding_siblings(node, name === '+'); | |||
There was a problem hiding this comment.
Renamed to clarify that it retreats previous siblings.
|
|
||
| walk_children(element.fragment, { is_child: true }); | ||
| sibling_elements ??= get_following_sibling_elements(element, include_self); | ||
| if (selectors.some((s) => s.combinator?.name === ' ' || s.combinator?.name === '>')) { |
There was a problem hiding this comment.
It doesn't cover s.combinator === null case - I suppose only the first selector can have no combinator.
7nik
changed the title
added 2 commits
February 4, 2025 18:28
|
So, now |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14072
:has()was matching only against descendants or siblings, but not sibling's descendants.Also, in a case like
:has(> .foo > .bar)it was matching against children instead of descendants, so I had to drop the>optimization. But, to ensure that in case like:has(> .foo)it matches only the direct children, the inner selector is prepended with a selector of new type that matches only certain element.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint