client: add a StaticWatcher utility constructor #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
commented
Aug 20, 2024
| // This is useful as a placeholder for development, migration, and testing. | ||
| // The value reported by a static watcher never changes, and the watcher | ||
| // channel is never ready. | ||
| func StaticWatcher(value string) Watcher { |
There was a problem hiding this comment.
This is the only new bit, the rest is moved from store.go
There was a problem hiding this comment.
After discussion, I am going to propose a different approach.
creachadair
force-pushed
the
mjf/static-watcher
branch
from
2a60c25
to
6378f76
Compare
creachadair
force-pushed
the
mjf/static-watcher
branch
from
6378f76
to
1d1e9a0
Compare
danderson
approved these changes
Aug 22, 2024
creachadair
force-pushed
the
mjf/static-watcher
branch
from
1d1e9a0
to
f955416
Compare
This helps with migration of secrets that need a Watcher in production, but which still need static values for development and testing. The resulting Watcher never notifies an update, but is valid and vends the provided secret. While here, pull all the static constructors out into their own file, as the store file is getting a bit unwieldy. Updates tailscale/corp#22445
creachadair
force-pushed
the
mjf/static-watcher
branch
from
f955416
to
2e268e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with migration of secrets that need a Watcher in production, but
which still need static values for development and testing. The resulting
Watcher never notifies an update, but is valid and vends the provided secret.
While here, pull all the static constructors out into their own file, as the
store file is getting a bit unwieldy.
Updates tailscale/corp#22445