Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: PhoneNumberValidator 1.3.1 #84

Open
wants to merge 100 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
6244691
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
ee90986
Update copyright year of initial setting
Anrufliste May 1, 2024
69b0acc
Initial testing 5 separated cases
Anrufliste May 4, 2024
ce2a4b9
Create Area Code Extractor (NDC) for Germany.
Anrufliste May 20, 2024
07d7ae0
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
b53fb1a
Starting Validator.
Anrufliste May 20, 2024
bf5daa1
Include Mobile NDCs into generator script for GermanAreaCodeExtractor…
Anrufliste May 21, 2024
a6832b1
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 22, 2024
b9b3c43
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
f69a826
Introducing INVALID_PREFIX_OF_SUBSCRIBER_NUMBER and reorganize expect…
Anrufliste Jun 3, 2024
b1b7490
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
664a31b
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
bb46ef8
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
b83ae4f
Adding todo in Validation Code to support not yet supported PhoneNumb…
Anrufliste Jun 4, 2024
e5c4aa2
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
da59839
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
705985d
Issue for +49115 resubmitted
Anrufliste Jun 21, 2024
9d0a7cc
Adding Validation test for 118(y)xx call assitant. Adapting Validatio…
Anrufliste Jun 23, 2024
b76d104
Initial testing 5 separated cases
Anrufliste May 4, 2024
350ffe3
Initial testing 5 separated cases
Anrufliste May 4, 2024
94848ec
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
850c359
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
761310a
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
88be199
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
e5ad7c3
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
f261f9e
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
8bc9b71
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
465cb12
Initial testing 5 separated cases
Anrufliste May 4, 2024
8016162
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
cf11847
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
81dd450
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
fce0089
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
cf90298
Initial testing 5 separated cases
Anrufliste May 4, 2024
ed89bd6
Initial testing 5 separated cases
Anrufliste May 4, 2024
f38bcd9
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
fdb475a
Starting Validator.
Anrufliste May 20, 2024
11e4eae
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
648ff8d
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
fb3d25f
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
3af3064
Merging 1.3.1 with Validator C
Anrufliste Oct 5, 2024
f1d3ec4
Use PhoneLib 8.13.48 and prepare release (#85)
Anrufliste Oct 24, 2024
31b9ecd
Update deploy.yml
Anrufliste Oct 24, 2024
f62abd2
Update maven.yml
Anrufliste Oct 24, 2024
86cc959
Update maven.yml
Anrufliste Oct 24, 2024
1c83c69
Update deploy.yml
Anrufliste Oct 24, 2024
70a63e6
Update deploy.yml
Anrufliste Oct 25, 2024
20973c6
Update pom.xml
Anrufliste Oct 25, 2024
5dddf0f
Update deploy.yml
Anrufliste Oct 25, 2024
6be3947
Use PhoneLib 8.13.49 and prepare release
Anrufliste Nov 7, 2024
efdf209
Merge pull request #86 from telekom/phonelib/8_13_49
Anrufliste Nov 7, 2024
5d9de6d
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
c7ca9c4
Update copyright year of initial setting
Anrufliste May 1, 2024
d18de77
Initial testing 5 separated cases
Anrufliste May 4, 2024
c3f85f3
Create Area Code Extractor (NDC) for Germany.
Anrufliste May 20, 2024
2b49536
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
c96b74f
Starting Validator.
Anrufliste May 20, 2024
363c351
Include Mobile NDCs into generator script for GermanAreaCodeExtractor…
Anrufliste May 21, 2024
8779bbc
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 22, 2024
6db8ae1
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
35c60b3
Introducing INVALID_PREFIX_OF_SUBSCRIBER_NUMBER and reorganize expect…
Anrufliste Jun 3, 2024
57db6a9
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
e87cadb
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
3eb8cd4
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
2911dc3
Adding todo in Validation Code to support not yet supported PhoneNumb…
Anrufliste Jun 4, 2024
d12300b
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
c456673
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
0e8af06
Issue for +49115 resubmitted
Anrufliste Jun 21, 2024
adb0915
Adding Validation test for 118(y)xx call assitant. Adapting Validatio…
Anrufliste Jun 23, 2024
eeb999e
Initial testing 5 separated cases
Anrufliste May 4, 2024
bae9cc2
Initial testing 5 separated cases
Anrufliste May 4, 2024
2110673
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
0d8d1f6
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
e6ac578
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
f8eca8a
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
fe424c0
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
94170ee
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
bcc2d18
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
0c918dc
Initial testing 5 separated cases
Anrufliste May 4, 2024
5ae81bf
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
8c1edb7
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
51555f1
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
0b513c5
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
dfc30b4
Initial testing 5 separated cases
Anrufliste May 4, 2024
90395cd
Initial testing 5 separated cases
Anrufliste May 4, 2024
b83cfc7
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
3d20146
Starting Validator.
Anrufliste May 20, 2024
e0f5c78
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
51bbfd0
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
c7c8aa4
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
b8b8718
Merging 1.3.1 with Validator C
Anrufliste Oct 5, 2024
f0b0a3a
comment adaption
Anrufliste Oct 23, 2024
9f9612c
Merge branch 'Validator_1_3_1' of https://github.com/telekom/phonenum…
Anrufliste Nov 7, 2024
d1d73d8
Adapt testing expectation to corrected PhoneLib behaviour
Anrufliste Nov 8, 2024
8469cbc
Adding 199 as NDC for National Operator Only.
Anrufliste Nov 8, 2024
7ccff35
Adding 700 as NDC for personal numbers.
Anrufliste Nov 9, 2024
8d33d00
List all NDC testcases which needs to be added at PhoneNumberValidato…
Anrufliste Nov 9, 2024
dcba45c
Adding ambulance transport 19222 short code
Anrufliste Nov 15, 2024
b75d2a1
Inluded 137 for validation and introduced new mechanism to detect res…
Anrufliste Nov 18, 2024
ea3d107
removed abdon approach for reserved number ranges
Anrufliste Nov 18, 2024
efec12b
Extend NDC extraction with phonelib RFC3966 formation for not improve…
Anrufliste Mar 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Optimize Validation Code by moving duplicate code structure into chec…
…kShortCodeOverlapping method and introduce ShortCodeUseable enum, to controll the usage of the isUsable... functions of the numberplan object.
Anrufliste committed Oct 5, 2024
commit 88be199f48a94fe9e6ce325d3e1904c0215e379e
Original file line number Diff line number Diff line change
@@ -529,7 +529,7 @@ class PhoneNumberValidatorImplTest extends Specification {
"0175 1155555" | "DE" | PhoneNumberValidationResult.IS_POSSIBLE_NATIONAL_ONLY // number starts with NAC, mandatory mobile NDC follows, so subscriber number is not overlapping with short codes - but SN length for this NDC is 7
"0175 11555555" | "DE" | PhoneNumberValidationResult.TOO_LONG // number starts with NAC, mandatory mobile NDC follows, so subscriber number is not overlapping with short codes - but SN length for this NDC is 7
"0175 115555555" | "DE" | PhoneNumberValidationResult.TOO_LONG // number starts with NAC, mandatory mobile NDC follows, so subscriber number is not overlapping with short codes - but SN length for this NDC is 7
"0203 115" | "DE" | PhoneNumberValidationResult.IS_POSSIBLE // number starts with NAC, optional fixed line NDC follows, SN equals short code and the local service is targeted regardless of caller location.
"0203 115" | "DE" | PhoneNumberValidationResult.IS_POSSIBLE_NATIONAL_ONLY // number starts with NAC, optional fixed line NDC follows, SN equals short code and the local service is targeted regardless of caller location.
"0203 115555" | "DE" | PhoneNumberValidationResult.INVALID_PREFIX_OF_SUBSCRIBER_NUMBER // number starts with NAC, optional fixed line NDC follows, SN starts with short code (overlapping) => assuming NDC is intended, which means SN is wrong
// using IDP+CC within the region
"+49115" | "DE" | PhoneNumberValidationResult.INVALID_COUNTRY_CODE // number starts with IDP+CC, normally NDC would follow, but that equals short code => inside germany explicitly not allowed (see BnetzA)