Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: PhoneNumberValidator 1.3.1 #84

Closed
wants to merge 100 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
6244691
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
ee90986
Update copyright year of initial setting
Anrufliste May 1, 2024
69b0acc
Initial testing 5 separated cases
Anrufliste May 4, 2024
ce2a4b9
Create Area Code Extractor (NDC) for Germany.
Anrufliste May 20, 2024
07d7ae0
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
b53fb1a
Starting Validator.
Anrufliste May 20, 2024
bf5daa1
Include Mobile NDCs into generator script for GermanAreaCodeExtractor…
Anrufliste May 21, 2024
a6832b1
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 22, 2024
b9b3c43
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
f69a826
Introducing INVALID_PREFIX_OF_SUBSCRIBER_NUMBER and reorganize expect…
Anrufliste Jun 3, 2024
b1b7490
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
664a31b
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
bb46ef8
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
b83ae4f
Adding todo in Validation Code to support not yet supported PhoneNumb…
Anrufliste Jun 4, 2024
e5c4aa2
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
da59839
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
705985d
Issue for +49115 resubmitted
Anrufliste Jun 21, 2024
9d0a7cc
Adding Validation test for 118(y)xx call assitant. Adapting Validatio…
Anrufliste Jun 23, 2024
b76d104
Initial testing 5 separated cases
Anrufliste May 4, 2024
350ffe3
Initial testing 5 separated cases
Anrufliste May 4, 2024
94848ec
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
850c359
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
761310a
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
88be199
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
e5ad7c3
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
f261f9e
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
8bc9b71
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
465cb12
Initial testing 5 separated cases
Anrufliste May 4, 2024
8016162
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
cf11847
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
81dd450
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
fce0089
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
cf90298
Initial testing 5 separated cases
Anrufliste May 4, 2024
ed89bd6
Initial testing 5 separated cases
Anrufliste May 4, 2024
f38bcd9
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
fdb475a
Starting Validator.
Anrufliste May 20, 2024
11e4eae
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
648ff8d
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
fb3d25f
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
3af3064
Merging 1.3.1 with Validator C
Anrufliste Oct 5, 2024
f1d3ec4
Use PhoneLib 8.13.48 and prepare release (#85)
Anrufliste Oct 24, 2024
31b9ecd
Update deploy.yml
Anrufliste Oct 24, 2024
f62abd2
Update maven.yml
Anrufliste Oct 24, 2024
86cc959
Update maven.yml
Anrufliste Oct 24, 2024
1c83c69
Update deploy.yml
Anrufliste Oct 24, 2024
70a63e6
Update deploy.yml
Anrufliste Oct 25, 2024
20973c6
Update pom.xml
Anrufliste Oct 25, 2024
5dddf0f
Update deploy.yml
Anrufliste Oct 25, 2024
6be3947
Use PhoneLib 8.13.49 and prepare release
Anrufliste Nov 7, 2024
efdf209
Merge pull request #86 from telekom/phonelib/8_13_49
Anrufliste Nov 7, 2024
5d9de6d
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
c7ca9c4
Update copyright year of initial setting
Anrufliste May 1, 2024
d18de77
Initial testing 5 separated cases
Anrufliste May 4, 2024
c3f85f3
Create Area Code Extractor (NDC) for Germany.
Anrufliste May 20, 2024
2b49536
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
c96b74f
Starting Validator.
Anrufliste May 20, 2024
363c351
Include Mobile NDCs into generator script for GermanAreaCodeExtractor…
Anrufliste May 21, 2024
8779bbc
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 22, 2024
6db8ae1
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
35c60b3
Introducing INVALID_PREFIX_OF_SUBSCRIBER_NUMBER and reorganize expect…
Anrufliste Jun 3, 2024
57db6a9
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
e87cadb
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
3eb8cd4
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
2911dc3
Adding todo in Validation Code to support not yet supported PhoneNumb…
Anrufliste Jun 4, 2024
d12300b
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
c456673
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
0e8af06
Issue for +49115 resubmitted
Anrufliste Jun 21, 2024
adb0915
Adding Validation test for 118(y)xx call assitant. Adapting Validatio…
Anrufliste Jun 23, 2024
eeb999e
Initial testing 5 separated cases
Anrufliste May 4, 2024
bae9cc2
Initial testing 5 separated cases
Anrufliste May 4, 2024
2110673
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
0d8d1f6
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
e6ac578
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
f8eca8a
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
fe424c0
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
94170ee
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
bcc2d18
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
0c918dc
Initial testing 5 separated cases
Anrufliste May 4, 2024
5ae81bf
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
8c1edb7
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
51555f1
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
0b513c5
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
dfc30b4
Initial testing 5 separated cases
Anrufliste May 4, 2024
90395cd
Initial testing 5 separated cases
Anrufliste May 4, 2024
b83cfc7
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
3d20146
Starting Validator.
Anrufliste May 20, 2024
e0f5c78
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
51bbfd0
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
c7c8aa4
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
b8b8718
Merging 1.3.1 with Validator C
Anrufliste Oct 5, 2024
f0b0a3a
comment adaption
Anrufliste Oct 23, 2024
9f9612c
Merge branch 'Validator_1_3_1' of https://github.com/telekom/phonenum…
Anrufliste Nov 7, 2024
d1d73d8
Adapt testing expectation to corrected PhoneLib behaviour
Anrufliste Nov 8, 2024
8469cbc
Adding 199 as NDC for National Operator Only.
Anrufliste Nov 8, 2024
7ccff35
Adding 700 as NDC for personal numbers.
Anrufliste Nov 9, 2024
8d33d00
List all NDC testcases which needs to be added at PhoneNumberValidato…
Anrufliste Nov 9, 2024
dcba45c
Adding ambulance transport 19222 short code
Anrufliste Nov 15, 2024
b75d2a1
Inluded 137 for validation and introduced new mechanism to detect res…
Anrufliste Nov 18, 2024
ea3d107
removed abdon approach for reserved number ranges
Anrufliste Nov 18, 2024
efec12b
Extend NDC extraction with phonelib RFC3966 formation for not improve…
Anrufliste Mar 3, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ jobs:
cat <(echo -e "${{ secrets.OSSRH_GPG_SECRET_KEY }}") | gpg --batch --import
# Verify gpg secret key
gpg --list-secret-keys --keyid-format LONG
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Maven Central Repository
uses: actions/setup-java@v1
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'temurin'
server-id: ossrh
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up JDK 11
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'temurin'
Expand Down
24 changes: 23 additions & 1 deletion REPORTED_ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ However, it’s possible that this has caused confusion about which parts of the
This issue addresses special short codes used for phone number directory assistant services.
This issue has been resolved.

Google [fixed](https://github.com/google/libphonenumber/pull/2601/files#diff-1887949025d4940ce0f39cc4ba17666b5d93be2f143867b77c26bcddb36ac696R3400) ít with [8.12.21](https://github.com/google/libphonenumber/pull/2601) on 15.05.2024.

### 2021-03-25 - [Germany (DE, +49): 116xxx Short Number valid vs. assigned](https://issuetracker.google.com/issues/183669955)

This issue pertains to the EU-wide special social number short code definition. Although the regulation clearly defines a range, PhoneLib is not validating against that range, but against a list of currently assigned/operated numbers. At least for the German number space, as mentioned in the initial issue discussion (see first one above), the library is only partly or even completely checking the whole range in other EU number spaces.
Expand Down Expand Up @@ -50,8 +52,28 @@ We have provided Ludwighafen in our labeling data.

Google [fixed](https://github.com/google/libphonenumber/pull/3473/files#diff-db8e5b3fb2cb4a7ed9856289ea12d54947bfaa10549e6c1058fec7f3a1359dbbR3260) ít with [8.13.37](https://github.com/google/libphonenumber/pull/3473) on 15.05.2024.

### 2024-05-22 - [Emergency Numbers must not be used with National Destination Code in Germany fixed line](https://issuetracker.google.com/issues/341947688)

BnetzA [described emergency short codes 110 & 112 as numbers without local NDC](https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/np_nummernraum.pdf?__blob=publicationFile&v=1), since NDC is optional in fixed line, no number might start with those three digits (otherwise using such a number without NDC would trigger the emergency call). In mobile networks NDC is mandatory, so a number might start with those three digits, since NDC would be a prefix. Real live examples have been found.

Google acknowledged the issue, but marked it as "**Won't fix (Intended behavior)**" because "*We will definitely think about it but it is not a priority right now. Also we have already mentioned about the complexity and invalid or false positive numbers in our XML file of Germany https://github.com/google/libphonenumber/blob/30db8f67a1c06b3ab052497477be1d9f18312387/resources/PhoneNumberMetadata.xml#L8126*" on 27.05.2024
Google [fixed](https://github.com/google/libphonenumber/pull/3473/files#diff-db8e5b3fb2cb4a7ed9856289ea12d54947bfaa10549e6c1058fec7f3a1359dbbR3260) ít with [8.13.37](https://github.com/google/libphonenumber/pull/3473) on 15.05.2024.

### 2024-06-08 - [Government Service Numbers may be used with National Destination Code in Germany fixed line, but subscriber numbers may not start with it](https://issuetracker.google.com/issues/345753226)

BnetzA [described government short codes 115](https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/115/115_Nummernplan_konsolidiert.pdf?__blob=publicationFile&v=1), no number might start with those three digits (otherwise using such a number would trigger the short code). Furthermore the short code might be called with IDP and Country code (**+49115**) but from outside Germany and not from within - here the used region must have an influence on the evaluation.

Google since 09.07.2024, the Issue is not publicly accessible anymore - we wrote a [post in the Google discussion group](https://groups.google.com/g/libphonenumber-discuss/c/WQv244-PVmI).

### 2024-06-16 - [+49115 German Government short number with IDP+CC is only valid from outside Germany but not within (so IS_POSSIBLE_LOCAL_ONLY is also wrong)](https://issuetracker.google.com/issues/347356467)

Since the previous Issue "disappeared" without notice, we assume, it was structural too similar to the emergencies number issue and the reviewer did not recordnized the differences. So we reported the main difference - again and this time the issue is at least accepted. But the reviewer comment seems only to focus on the short number call-ability from outside the country and not that IDP+CC+115 must not be used from inside.

### 2024-09-03 - [German Mobile number length validation for range 17x inconsistently differentiated in 8.13.43](https://issuetracker.google.com/issues/364179199)

Previous to Version 8.13.43 any German number within the range 17x was identified valid for both length 10 & 11. Now the 11 length case (176) is differentiated, that 176 is not validated valid with 10 digits. But 170-175, 177-179 is still validated valid for both length, but should be only valid with length of 10.

Google stated it is aware and will bring changes after investigation that users are not unblock.
Google stated it is aware and will bring changes after investigation that users are not unblock.

Google [fixed](https://github.com/google/libphonenumber/pull/3671/files#diff-5061a7d3c54ba589aacce00dcee1ce92e098c40034749bcae4c8a4780bb40233) it with [8.13.48](https://github.com/google/libphonenumber/pull/3671) on 16.10.2024
While normal mobile numbers are now aligend, voicemail numbers length is still problematic (BUG needs to be reported!).
8 changes: 4 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<artifactId>normalizer</artifactId>
<name>Phonenumber Normalizer</name>
<description>Library to work with phonenumbers, especially to fix googles PhoneLib ignoring German Landline specifics.</description>
<version>1.3.1-SNAPSHOT</version>
<version>1.3.2</version>
<packaging>jar</packaging>
<url>https://github.com/telekom/phonenumber-normalizer</url>

Expand Down Expand Up @@ -86,7 +86,7 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>libphonenumber</artifactId>
<version>8.13.47</version>
<version>8.13.49</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -150,7 +150,7 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>geocoder</artifactId>
<version>2.241</version>
<version>2.243</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -428,4 +428,4 @@
<url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url>
</repository>
</distributionManagement>
</project>
</project>
Loading