feat: Add cmake & ninja build requirements only when needed #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than listing `cmake` and `ninja` build requirements unconditionally, add them to `setup_requires` when they are necessary -- that is, when using skbuild and when the system installations of these tools are not available. This avoids installing the packages unnecessarily, and improves portability by using downstream patched CMake version when available.
ddelange
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than listing
cmakeandninjabuild requirements unconditionally, add them tosetup_requireswhen they are necessary -- that is, when using skbuild and when the system installations of these tools are not available. This avoids installing the packages unnecessarily, and improves portability by using downstream patched CMake version when available.